Skip to content

[DPL Analysis] Canonical task names#5640

Merged
ktf merged 7 commits into
AliceO2Group:devfrom
saganatt:object-suffix
Mar 9, 2021
Merged

[DPL Analysis] Canonical task names#5640
ktf merged 7 commits into
AliceO2Group:devfrom
saganatt:object-suffix

Conversation

@saganatt

@saganatt saganatt commented Mar 6, 2021

Copy link
Copy Markdown
Collaborator

Hi @ktf, @jgrosseo
what do you think about canonizing the task names in this way?

@ktf

ktf commented Mar 6, 2021

Copy link
Copy Markdown
Member

Very nice. Let's see if it's constexpr everywhere.

@jgrosseo

jgrosseo commented Mar 6, 2021

Copy link
Copy Markdown
Collaborator

I like it :)

@ktf

ktf commented Mar 6, 2021

Copy link
Copy Markdown
Member

@saganatt any reason for it to be draft?

@saganatt saganatt marked this pull request as ready for review March 6, 2021 23:22
@saganatt saganatt requested review from a team, iarsene and jgrosseo as code owners March 6, 2021 23:22
@saganatt

saganatt commented Mar 6, 2021

Copy link
Copy Markdown
Collaborator Author

@saganatt any reason for it to be draft?

Nope, just somewhat I thought the rest of tasks won't compile but only today I realized I made it backward-compatible on purpose ;-)

@saganatt

saganatt commented Mar 6, 2021

Copy link
Copy Markdown
Collaborator Author

Very nice. Let's see if it's constexpr everywhere.

I set as many constexpr as possible (testing with GCC 7). We don't need constexpr for ClassName->task-name conversion, do we?

@saganatt

saganatt commented Mar 7, 2021

Copy link
Copy Markdown
Collaborator Author

@saganatt any reason for it to be draft?

Nope, just somewhat I thought the rest of tasks won't compile but only today I realized I made it backward-compatible on purpose ;-)

Oops my first intuition was good, it needed change in all analysis tasks.

@ktf

ktf commented Mar 8, 2021

Copy link
Copy Markdown
Member

Very nice. Let's see if it's constexpr everywhere.

I set as many constexpr as possible (testing with GCC 7). We don't need constexpr for ClassName->task-name conversion, do we?

No, we don't.

jgrosseo
jgrosseo previously approved these changes Mar 8, 2021
@ktf ktf merged commit 7569c96 into AliceO2Group:dev Mar 9, 2021
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants