Skip to content

[DPL Analysis] Canonical task names #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 7 commits into from
Mar 9, 2021
Merged

[DPL Analysis] Canonical task names #5640

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2cf4a1
Canonised task name
saganatt Mar 6, 2021
9aa0828
One more constexpr
saganatt Mar 6, 2021
033c641
Prettier task name
saganatt Mar 6, 2021
20edc4b
Inserting TaskName to all analysis tasks
saganatt Mar 7, 2021
47c69d4
Remove constexpr for gcc 8
saganatt Mar 7, 2021
285f6fa
Fixes
saganatt Mar 8, 2021
dc484d9
The right(?) trick for macOS Clang
saganatt Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove constexpr for gcc 8
  • Loading branch information
@saganatt
saganatt committed Mar 8, 2021
commit 47c69d45cdbe525909b695641c9b2ade4772bf45
10 changes: 5 additions & 5 deletions Framework/Foundation/include/Framework/TypeIdHelpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,12 @@ namespace detail

using type_name_prober = void;

PRETTY_FUNCTION_CONSTEXPR static std::size_t wrapped_type_name_prefix_length()
static std::size_t wrapped_type_name_prefix_length() const
{
return unique_type_id_v<type_name_prober>.find(type_name<type_name_prober>());
}

PRETTY_FUNCTION_CONSTEXPR static std::size_t wrapped_type_name_suffix_length()
static std::size_t wrapped_type_name_suffix_length() const
{
return unique_type_id_v<type_name_prober>.length() - wrapped_type_name_prefix_length() - type_name<type_name_prober>().length();
}
Expand All @@ -83,9 +83,9 @@ template <typename T>
constexpr static std::string_view type_name()
{
constexpr std::string_view wrapped_name{unique_type_id_v<T>};
PRETTY_FUNCTION_CONSTEXPR auto prefix_length = detail::wrapped_type_name_prefix_length();
PRETTY_FUNCTION_CONSTEXPR auto suffix_length = detail::wrapped_type_name_suffix_length();
PRETTY_FUNCTION_CONSTEXPR auto type_name_length = wrapped_name.length() - prefix_length - suffix_length;
const auto prefix_length = detail::wrapped_type_name_prefix_length();
const auto suffix_length = detail::wrapped_type_name_suffix_length();
const auto type_name_length = wrapped_name.length() - prefix_length - suffix_length;
return wrapped_name.substr(prefix_length, type_name_length);
}

Expand Down