Skip to content

[DPL Analysis] Canonical task names #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 7 commits into from
Mar 9, 2021
Merged

[DPL Analysis] Canonical task names #5640

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2cf4a1
Canonised task name
saganatt Mar 6, 2021
9aa0828
One more constexpr
saganatt Mar 6, 2021
033c641
Prettier task name
saganatt Mar 6, 2021
20edc4b
Inserting TaskName to all analysis tasks
saganatt Mar 7, 2021
47c69d4
Remove constexpr for gcc 8
saganatt Mar 7, 2021
285f6fa
Fixes
saganatt Mar 8, 2021
dc484d9
The right(?) trick for macOS Clang
saganatt Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prettier task name
  • Loading branch information
@saganatt
saganatt committed Mar 8, 2021
commit 033c641c571daadc5e4b37ea68e89e9ab8159e3f
4 changes: 2 additions & 2 deletions Analysis/Tutorials/src/histograms.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ struct BTask {
}
};

struct CTask {
struct PtHistogram {
// needs to be initialized with a label or an obj
// when adding an object to OutputObj later, the object name will be
// *reset* to OutputObj label - needed for correct placement in the output file
Expand Down Expand Up @@ -104,7 +104,7 @@ WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
return WorkflowSpec{
adaptAnalysisTask<ATask>(cfgc, TaskName{"eta-and-phi-histograms"}),
adaptAnalysisTask<BTask>(cfgc, TaskName{"etaphi-histogram"}),
adaptAnalysisTask<CTask>(cfgc), //, TaskName{"pt-histogram"}),
adaptAnalysisTask<PtHistogram>(cfgc), //, TaskName{"pt-histogram"}),
adaptAnalysisTask<DTask>(cfgc, TaskName{"output-wrapper"}),
};
}