Sobol sampler implemented #413
Conversation
|
This pull request introduces 1 alert when merging 37c56d2 into 2a5bbdc - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging eba410c into 2a5bbdc - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 4400786 into 840d6af - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 9a8bb39 into 840d6af - view on LGTM.com new alerts:
|
|
I forgot to write the test!. I'll write it! |
PathPlanning/RRT/sobol/sobol.py
Outdated
| import sys | ||
| import numpy as np | ||
|
|
||
| # from numpy import np.bitwise_xor |
There was a problem hiding this comment.
Please remove this line if it is not needed.
PathPlanning/RRT/sobol/sobol.py
Outdated
| global seed_save | ||
| global v | ||
|
|
||
| if 'initialized' is None: |
There was a problem hiding this comment.
Please fix code scanning warning.
PathPlanning/RRT/sobol/sobol.py
Outdated
| Input, real A(M,N), the matrix. | ||
|
|
||
| """ | ||
| output = open(filename, 'w') |
There was a problem hiding this comment.
Please fix code scanning warning.
There was a problem hiding this comment.
Can you use with statement? like
with open(filename, 'w') as f:
for i in range(0, m):
|
This pull request introduces 1 alert when merging 4b13c91 into 40df009 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging fbebc7d into 40df009 - view on LGTM.com new alerts:
|
| seed = 0 | ||
|
|
||
| if (seed == 0): | ||
| l_var = 1 |
There was a problem hiding this comment.
lgtm.com reports this line as unnecessary code, because l_var is already 1 in line 417.
PathPlanning/RRT/sobol/sobol.py
Outdated
| elif (seed <= seed_save): | ||
|
|
||
| seed_save = 0 | ||
| l_var = 1 |
PathPlanning/RRT/sobol/sobol.py
Outdated
| Input, real A(M,N), the matrix. | ||
|
|
||
| """ | ||
| output = open(filename, 'w') |
There was a problem hiding this comment.
Can you use with statement? like
with open(filename, 'w') as f:
for i in range(0, m):
|
This pull request introduces 1 alert when merging 6b219a7 into e30696a - view on LGTM.com new alerts:
|
What does this implement?
This pull request implements a low discrepancy sequence for the generation of sample points in the RRT method.
Low discrepancy sampler are preferred over uniform random distribution because they provide a more evenly distributed sequence of points.
The Sobol sequence was implemented using the code with MIT licence available here.
Additional information
Sorry if I did not create an Issue before, but the pull request was very straight forward. If it is necessary, I can create the issue.