Stats: Update method for inserting JavaScript - Removed fallback / workaround for themes without wp_footer #13182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After discussion on Github issue "Stats: Update method for inserting JavaScript Automattic#3763" it was considered that it was a safe assumption to make that a theme would always have a `wp_footer` action. This update removes code which was used to provide a fallback / workaround in the case of themes which did not contain a `wp_footer` action. The workaround consisted of setting a global variable `$rendered_stats_footer` which would get set to true if the `wp_footer` call was successful, if not successful then the WP Stats JS code would get set via a `wp_head` action instead.
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: August 6, 2019. |
jeherve
previously approved these changes
Aug 5, 2019
jeherve
added
[Status] Needs Author Reply
Fixed incorrect use of spaces instead of tabs
jeherve
added
[Status] Needs Review
jeherve
added
[Status] Ready to Merge
mdawaffe
approved these changes
Aug 16, 2019
Member
mdawaffe
left a comment
mdawaffe
left a comment
There was a problem hiding this comment.
LGTM. Note that this does not address the originally reported SRI issue.
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
jeherve
added a commit
that referenced
this pull request
Aug 27, 2019
* 7.7 changelog: initial set of changes * Changelog: add #13154 * Changelog: add #13134 * Changelog: add #12699 and many others * Changelog: add #13127 * Changelog: add #13167 * Changelog: add #13225 * Changelog: add #13179 * Changelog: add #13173 * Changelog: add #13232 * Changelog: add #13137 * Changelog: add #13172 * Changelog: add #13182 * Changelog: add #13200 * Changelog: add #13244 * Changelog: add #13267 * Changelog: add #13204 * changelog: add #13205 * Changelog: add #13183 * Changelog: add #13278 * Changelog: add #13162 * Changelog: add #13268 * Changelog: add #13286 * Changelog: add #13273 * Changelog: add #12474 * Changelog: add #13085 * Changelog: add #13266 * Changelog: add #13306 * Changelog: add #13311 * Changelog: add #13302 * Changelog: add #13196 * Changelog: add #12733 * Changelog: add #13261 * Changelog: add #13322 * Changelog: add #13333 * Changelog: add #13335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion on Github issue "Stats: Update method for inserting JavaScript #3763" it was considered that it was a safe assumption to make that a theme would always have a
wp_footeraction.This update removes and modifies code which was used to provide a fallback / workaround in the case of themes that did not contain a
wp_footeraction.The workaround consisted of setting a global variable
$rendered_stats_footerwhich would get set to true if thewp_footercall was successful, if not successful then the WP Stats JS code would get set via awp_headaction instead.wp_footer.