Use Post ID instead of Post Object in current_user_can #13286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htdat
added
[Type] Bug
matticbot
added
Customer Report [LEGACY]
Contributor
|
Caution: This PR has changes that must be merged to WordPress.com |
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: September 3, 2019. |
jeherve
added
[Status] Ready to Merge
jeherve
approved these changes
Aug 21, 2019
Member
jeherve
left a comment
jeherve
left a comment
There was a problem hiding this comment.
Thanks for taking care of this! 👍
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
jeherve
added a commit
that referenced
this pull request
Aug 27, 2019
* 7.7 changelog: initial set of changes * Changelog: add #13154 * Changelog: add #13134 * Changelog: add #12699 and many others * Changelog: add #13127 * Changelog: add #13167 * Changelog: add #13225 * Changelog: add #13179 * Changelog: add #13173 * Changelog: add #13232 * Changelog: add #13137 * Changelog: add #13172 * Changelog: add #13182 * Changelog: add #13200 * Changelog: add #13244 * Changelog: add #13267 * Changelog: add #13204 * changelog: add #13205 * Changelog: add #13183 * Changelog: add #13278 * Changelog: add #13162 * Changelog: add #13268 * Changelog: add #13286 * Changelog: add #13273 * Changelog: add #12474 * Changelog: add #13085 * Changelog: add #13266 * Changelog: add #13306 * Changelog: add #13311 * Changelog: add #13302 * Changelog: add #13196 * Changelog: add #12733 * Changelog: add #13261 * Changelog: add #13322 * Changelog: add #13333 * Changelog: add #13335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Similar to #13166,
current_user_canonly accepts object IDs as the optional second param; passing anything else (like an instance of Jetpack_Post like we did) will cause issues.However, #13166 did not fix all wrong implementations so the same issue happens in 2184839-zen, then it was reported in 4206-gh-jpop-issues.
This PR is to correct all wrong implementations. In fact, only changes in
sal/class.json-api-post-base.phpis enough to fix this fatal error. However, I've tried my best, then found out other wrong implementations injson-endpoints/class.wpcom-json-api-post-endpoint.php.Testing instructions:
Proposed changelog entry for your changes: