Adds full connection cycle capability to the Connection package. #12699

zinigor · 2019-06-14T23:22:50Z

Changes proposed in this Pull Request:

[x] Adds the register method to the Connection package.
[x] Hooks the register verification method for registration verification.
[x] Adds multisite registration capability.
[x] Makes sure the methods are moved with only the needed dependencies.
[x] Makes sure the example plugin is able to connect using only the dependent packages and minimal boilerplate code.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

This PR aims to make the Connection package usable without the Jetpack plugin itself.

Testing instructions:

Use the example client plugin on a clean WordPress site. It's bare bones, it has one administration page where it displays some debugging information, as well as lets you press a button to run the registration process. You should see that the site properly generates secrets, but can't proceed with user registration because handlers are not yet in place.

Proposed changelog entry for your changes:

N/A

jetpackbot · 2019-06-14T23:25:01Z

	Warnings
⚠️	`pre-commit` hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against c86a4b8

packages/connection/src/Manager.php

tyxla · 2019-06-17T12:45:19Z

packages/connection/src/Manager.php

+		$args['body'] = $this->apply_activation_source_to_args( $args['body'] );
+
+		// TODO: fix URLs for bad hosts
+		$response = \Jetpack_Client::_wp_remote_request(


What about this one? Are we planning to move it to a package?

Yes, I'm hoping to merge Michael's #12717 into this PR once it gets merged.

gravityrail · 2019-06-18T05:07:08Z

jetpack.php

 // @todo: Abstract out the admin functions, and only include them if is_admin()
 require_once( JETPACK__PLUGIN_DIR . 'class.jetpack.php'               );
 require_once( JETPACK__PLUGIN_DIR . 'class.jetpack-network.php'       );
-require_once( JETPACK__PLUGIN_DIR . 'class.jetpack-client.php'        );


This line disappearing is my favourite thing about this PR

mdawaffe · 2019-07-18T17:10:29Z

Example client plugin worked for me, and what I understand about the changes make sense :)

mdawaffe · 2019-07-18T23:25:37Z

491016a3f344e92d3f25bb28046d4dc52a51db70 moved the $network_wpcom_blog_id = Jetpack_Options::get_option( 'id' ); to after the switch_to_blog(), so we're sending the subsite's wpcom_blog_id (which doesn't exist yet) in the subsite registration request. We should be sending the main site's wpcom_blog_id.

3ecdad75cf619f60dbb8c64294f7e133e7fb046f provides a sort of hacky fix (by unswitching/reswitching the blog).

matticbot · 2019-07-19T17:05:55Z

This PR looks like it might contain user tracking functions. We need to make sure that it is GDPR Compliant.

Rules triggering this positive scan:

Called "record_user_event" function.

cc: @pesieminski

packages/connection/src/Manager.php

packages/connection/legacy/class.jetpack-xmlrpc-server.php

packages/connection/src/Manager.php

… initialized

tyxla · 2019-08-08T11:42:31Z

I think this is ready for another review!

More info on how to test it in p1HpG7-7lI-p2 and its comments.

lezama

Things look to still connect and work, let's merge early and keep iterating and testing around this through the entire current cycle.

Great work @zinigor and @tyxla!

lezama

re approving after my last commit :)

* 7.7 changelog: initial set of changes * Changelog: add #13154 * Changelog: add #13134 * Changelog: add #12699 and many others * Changelog: add #13127 * Changelog: add #13167 * Changelog: add #13225 * Changelog: add #13179 * Changelog: add #13173 * Changelog: add #13232 * Changelog: add #13137 * Changelog: add #13172 * Changelog: add #13182 * Changelog: add #13200 * Changelog: add #13244 * Changelog: add #13267 * Changelog: add #13204 * changelog: add #13205 * Changelog: add #13183 * Changelog: add #13278 * Changelog: add #13162 * Changelog: add #13268 * Changelog: add #13286 * Changelog: add #13273 * Changelog: add #12474 * Changelog: add #13085 * Changelog: add #13266 * Changelog: add #13306 * Changelog: add #13311 * Changelog: add #13302 * Changelog: add #13196 * Changelog: add #12733 * Changelog: add #13261 * Changelog: add #13322 * Changelog: add #13333 * Changelog: add #13335

)

zinigor added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Focus] Jetpack DNA labels Jun 14, 2019

zinigor added this to the 7.5 milestone Jun 14, 2019

zinigor requested review from a team, gititon and tyxla June 14, 2019 23:22

tyxla reviewed Jun 17, 2019

View reviewed changes

zinigor mentioned this pull request Jun 17, 2019

Convert Jetpack_XMLRPC_Server to a classmapped package. #12711

Closed

gravityrail reviewed Jun 18, 2019

View reviewed changes

jeherve assigned zinigor Jun 20, 2019

jeherve mentioned this pull request Jun 20, 2019

Jetpack DNA: Connection package update #12539

Closed

zinigor modified the milestones: 7.5, 7.6 Jun 20, 2019

allendav mentioned this pull request Jun 28, 2019

Epic: Incorporate Jetpack DNA Connection package Automattic/woocommerce-payments#111

Closed

15 tasks

DanReyLop mentioned this pull request Jul 5, 2019

Use Jetpack Connection to authenticate Automattic/woocommerce-payments#131

Closed

zinigor force-pushed the add/user-authentication branch 2 times, most recently from af22078 to ad40999 Compare July 10, 2019 17:29

zinigor force-pushed the add/user-authentication branch from 3ecdad7 to 117a651 Compare July 19, 2019 13:12

zinigor requested a review from a team as a code owner July 19, 2019 16:23

matticbot added the [Status] Needs GDPR Review label Jul 19, 2019

mdawaffe reviewed Jul 19, 2019

View reviewed changes

packages/connection/src/Manager.php Outdated Show resolved Hide resolved

mdawaffe reviewed Jul 19, 2019

View reviewed changes

packages/connection/legacy/class.jetpack-xmlrpc-server.php Outdated Show resolved Hide resolved

mdawaffe reviewed Jul 19, 2019

View reviewed changes

packages/connection/src/Manager.php Outdated Show resolved Hide resolved

mdawaffe reviewed Jul 19, 2019

View reviewed changes

packages/connection/src/Manager.php Outdated Show resolved Hide resolved

zinigor mentioned this pull request Jul 29, 2019

Connection: Instantiate the XML-RPC Connector after adding Bootstrap Methods #13139

Merged

tyxla added 6 commits August 8, 2019 12:32

Statically access verify_xml_rpc_signature to make sure connection is…

77e5592

… initialized

Always access verify_xml_rpc_signature from the connection package

c39d030

No need to init when calling ::connection()

d90877c

Make use of __DIR__

34f7c85

Add Jetpack_XMLRPC_Server to the autoloader ignore list

f1f2876

Use api_url from the connection package in Jetpack_Client_Server

8026020

tyxla requested review from a team and gravityrail August 8, 2019 11:42

tyxla added the Connect Flow Connection banners, buttons, ... label Aug 8, 2019

lezama previously approved these changes Aug 8, 2019

View reviewed changes

don't require class.jetpack-xmlrpc-server.php

c86a4b8

lezama dismissed their stale review via c86a4b8 August 8, 2019 16:47

lezama approved these changes Aug 8, 2019

View reviewed changes

lezama merged commit 0118cad into master Aug 8, 2019

lezama deleted the add/user-authentication branch August 8, 2019 17:19

matticbot added [Status] Needs Changelog and removed [Status] Needs Review This PR is ready for review. labels Aug 8, 2019

jeherve added [Status] Has Changelog and removed [Status] Needs Changelog labels Aug 23, 2019

jeherve added a commit that referenced this pull request Aug 23, 2019

Changelog: add #12699 and many others

ffd1aaf

kraftbj pushed a commit that referenced this pull request Dec 9, 2019

Adds full connection cycle capability to the Connection package. (#12699

d9060bd

)

anomiex mentioned this pull request May 15, 2024

Jetpack Connection: Add inline comments when whole input is processed #37392

Merged

3 tasks

Adds full connection cycle capability to the Connection package. #12699

Adds full connection cycle capability to the Connection package. #12699

Uh oh!

Conversation

zinigor commented Jun 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this Pull Request:

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Testing instructions:

Proposed changelog entry for your changes:

Uh oh!

jetpackbot commented Jun 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tyxla Jun 17, 2019

Choose a reason for hiding this comment

Uh oh!

zinigor Jun 18, 2019

Choose a reason for hiding this comment

Uh oh!

gravityrail Jun 18, 2019

Choose a reason for hiding this comment

Uh oh!

mdawaffe commented Jul 18, 2019

Uh oh!

mdawaffe commented Jul 18, 2019

Uh oh!

matticbot commented Jul 19, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tyxla commented Aug 8, 2019

Uh oh!

lezama left a comment

Choose a reason for hiding this comment

Uh oh!

lezama left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

zinigor commented Jun 14, 2019 •

edited

Loading

jetpackbot commented Jun 14, 2019 •

edited

Loading