Skip to content

Conversation

@tyxla
Copy link
Member

@tyxla tyxla commented Aug 15, 2019

In #12699 we forgot to port the JSON API auth functionality to the connection package 😱 You can see that there's a reference to $this->login_form_json_api_authorization in the connection manager, but that method doesn't exist 😕

This PR puts it back to the Jetpack class where it belongs, as the method we're using still lives there.

This is a better alternative than the approach initially suggested in #13224.

Changes proposed in this Pull Request:

  • Connection: Move out the JSON API auth hooking.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • This is a continuation of this effort: p1HpG7-7lI-p2

Testing instructions:

Proposed changelog entry for your changes:

  • Connection: Move out the JSON API auth hooking bit

@tyxla tyxla added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Pri] High Connect Flow Connection banners, buttons, ... labels Aug 15, 2019
@tyxla tyxla added this to the 7.7 milestone Aug 15, 2019
@tyxla tyxla requested review from a team, mdawaffe and zinigor August 15, 2019 11:10
@tyxla tyxla self-assigned this Aug 15, 2019
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: September 3, 2019.
Scheduled code freeze: August 27, 2019

Generated by 🚫 dangerJS against c20ad3f

Copy link
Member

@mdawaffe mdawaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@mdawaffe mdawaffe added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Aug 17, 2019
@tyxla tyxla merged commit 2d91095 into master Aug 19, 2019
@tyxla tyxla deleted the update/move-json-api-auth-out-of-connection branch August 19, 2019 08:09
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Connect Flow Connection banners, buttons, ... [Pri] High [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants