Skip to content

Conversation

@tyxla
Copy link
Member

@tyxla tyxla commented Aug 19, 2019

In #12699 we didn't port the remote media upload functionality to the connection package, but we moved a call to the responsible method in the connection manager 😱 You can see that there's a reference to $this->add_remote_request_handlers in the connection manager, but that method doesn't exist 😕

This PR puts the remote media upload initialization back to the Jetpack class where it belongs, as the method we're using still lives there. This is similar to what #13235 did for the JSON API auth.

Kudos to @brbrr for reporting that.

Changes proposed in this Pull Request:

  • Connection: Move remote file upload handlers back to Jetpack class

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • This is a continuation of this effort: p1HpG7-7lI-p2

Testing instructions:

  • Apply this patch to your Jetpack on a connected site.
  • Try uploading a file from Calypso to your site.

Proposed changelog entry for your changes:

  • Connection: Move remote file upload handlers back to Jetpack class

@tyxla tyxla added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Pri] High Connect Flow Connection banners, buttons, ... [Focus] Jetpack DNA labels Aug 19, 2019
@tyxla tyxla added this to the 7.7 milestone Aug 19, 2019
@tyxla tyxla requested review from a team, brbrr, mdawaffe and zinigor August 19, 2019 08:44
@tyxla tyxla self-assigned this Aug 19, 2019
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: September 3, 2019.
Scheduled code freeze: August 27, 2019

Generated by 🚫 dangerJS against 9808fd4

Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my tests! Thanks for the PR 🚢

@brbrr brbrr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Aug 19, 2019
@tyxla tyxla merged commit 12c82f4 into master Aug 19, 2019
@tyxla tyxla deleted the fix/connection-package-media-upload-handlers branch August 19, 2019 12:36
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Connect Flow Connection banners, buttons, ... [Focus] Jetpack DNA [Pri] High [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants