-
Notifications
You must be signed in to change notification settings - Fork 846
Full Site Editing: Add is_fse_eligible property to the Site object in the REST API
#14178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is an automated check which relies on |
|
Caution: This PR has changes that must be merged to WordPress.com |
jeherve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
Merging.
* Changelog: 8.1 additions * Changelog: add #13858 * Changelog: add #13963 * Changelog: add #14174 * Changelog: add #14178 * Changelog: add #14175 * Changelog: add #14192 * Changelog: add #14196 * Changelog: add #14182 * Changelog: add #14218 * Changelog: add #14214 * Changelog: add #13757 * Changelog: add #14190 * Changelog: add #14131 * Changelog: add #14101 * Changelog: add #14203 * Changelog: add #14211 * Changelog: add #14224 * Changelog: add #14230 * Changelog: add #14241 * Changelog: add #14249 * Changelog: add #14264 * Changelog: add #14263 * Changelog: add #14256 * Changelog: add #10189 * Changelog: add #14240 * Changelog: add #14239 Also added some new entries to the testing file. Co-authored-by: Igor Zinovyev <[email protected]>
* Changelog: 8.1 additions * Changelog: add #13858 * Changelog: add #13963 * Changelog: add #14174 * Changelog: add #14178 * Changelog: add #14175 * Changelog: add #14192 * Changelog: add #14196 * Changelog: add #14182 * Changelog: add #14218 * Changelog: add #14214 * Changelog: add #13757 * Changelog: add #14190 * Changelog: add #14131 * Changelog: add #14101 * Changelog: add #14203 * Changelog: add #14211 * Changelog: add #14224 * Changelog: add #14230 * Changelog: add #14241 * Changelog: add #14249 * Changelog: add #14264 * Changelog: add #14263 * Changelog: add #14256 * Changelog: add #10189 * Changelog: add #14240 * Changelog: add #14239 Also added some new entries to the testing file. Co-authored-by: Igor Zinovyev <[email protected]>
This syncs changes in WPCOM from D36164-code and D36219-code, where an
is_fse_eligibleproperty is added to the Site object in the REST API. For Full Site Editing this allows the site to flag whether or not it's eligible for FSE (e.g. the plugin is installed and activated), even if the current theme doesn't support FSE.Changes proposed in this Pull Request:
is_fse_eligibleproperty to the Get Site endpoint, e.g.https://public-api.wordpress.com/rest/v1.1/sites/<site_id>is_fse_eligiblefunction that callsis_site_eligible_for_full_site_editing()within the Full Site Editing function — returning whether the site is eligible for FSE irrespective of whether the current theme supports FSE.Is this a new feature or does it add/remove features to an existing part of Jetpack?
is_fse_activeproperty to the Site object in the REST API #13196 that added theis_fse_activeproperty. This new propertyis_fse_eligibleis slightly different, but has a similar implementation and has already been deployed to WPCOM in D36164-code and D36219-code, so now needs synced to Jetpack so that Jetpack sites can support the additional property.Testing instructions:
Before checking out this change
https://public-api.wordpress.com/rest/v1.1/sites/<site_id>from an authenticated environment, e.g. https://developer.wordpress.com/docs/api/console/ or usingwpcom.req.get('/sites/<site_id_or_domain>').then( function( result ) { console.log( result ) } );');from the console incalypso.localhost:3000.is_fse_activeand nois_fse_eligibleproperty.http://localhost:4040/inspect/httpyou should see that the POST request to/xmlrpc.phpincludes the stringis_fse_eligiblein its payload.Apply this change
is_fse_eligible: falseis_fse_eligible: falseis_fse_eligible: truein the response object.Proposed changelog entry for your changes: