Updates Backup launch price UX #14203

ChaosExAnima · 2019-12-10T20:46:34Z

Changes proposed in this Pull Request:

This updates the promo copy and styling for the new JP Backup plans.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

1142395350490785-as-1152991457460141

Testing instructions:

Go to My Plans page without the backup plan.
Compare JP feature area to design.

Note: Functionality for switching between yearly and monthly states is not in scope of this PR.

Before (desktop): https://d.pr/i/R5KeBx
Before (mobile): https://d.pr/i/97e3qz

After (desktop): https://d.pr/i/qnMG5O
After (mobile): https://d.pr/i/amep9G

After, monthly: https://d.pr/i/psGySU

Proposed changelog entry for your changes:

N/A, part of wider JP Backup release notes.

jetpackbot · 2019-12-10T20:48:59Z

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 14, 2020.
Scheduled code freeze: January 7, 2020

Generated by 🚫 dangerJS against dbe2478

_inc/client/plans/single-product-backup.jsx

_inc/client/plans/single-product-backup.scss

ChaosExAnima · 2019-12-11T20:27:12Z

Fixed all issues flagged for me, let me know if there's anything missing or more optimal ways to structure things. Thanks!

delawski

Great work, @ChaosExAnima!

I reviewed the code and left some suggestions. I don't there are any blockers, but I think they are worth considering in follow-up pushes.

_inc/client/scss/variables/_colors.scss

_inc/client/plans/single-product-backup.jsx

_inc/client/plans/single-product-backup.scss

_inc/client/plans/single-product-backup.jsx

tyxla

This is working well, nice work @ChaosExAnima!

It's a big PR though, I would have loved it if we could some of the following in separate PRs:

Billing timeframe handling and logic
Componentization - moving/building functionality to subcomponents

I've also left some comments and questions, let me know what you think.

_inc/client/plans/single-product-backup.jsx

ChaosExAnima · 2019-12-12T21:12:05Z

Answered a few things. Will address last items tomorrow.

Thank you for the thorough review @delawski and @tyxla!

_inc/client/plans/single-product-backup.jsx

matticbot · 2019-12-13T19:15:40Z

Caution: This PR has changes that must be merged to WordPress.com
Hello ChaosExAnima! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D36751-code before merging this PR. Thank you!

delawski · 2019-12-17T09:15:58Z

Thank you for the updates, @ChaosExAnima! I left just a minor comment. Other than that (and Marin's feedback), I think it's good to go 👍

tyxla · 2019-12-17T09:36:16Z

Addressed all the feedback. This is ready for another round of reviews - @delawski mind taking another 👀 ?

delawski

Everything looks good to me now! Let's 🚢it!

tyxla

This looks good now. @delawski can you take a look and ✅ it too before 🚢 ?

delawski · 2019-12-17T09:55:23Z

It's better now, @tyxla 👍Let's have it like this and ship!

* Changelog: 8.1 additions * Changelog: add #13858 * Changelog: add #13963 * Changelog: add #14174 * Changelog: add #14178 * Changelog: add #14175 * Changelog: add #14192 * Changelog: add #14196 * Changelog: add #14182 * Changelog: add #14218 * Changelog: add #14214 * Changelog: add #13757 * Changelog: add #14190 * Changelog: add #14131 * Changelog: add #14101 * Changelog: add #14203 * Changelog: add #14211 * Changelog: add #14224 * Changelog: add #14230 * Changelog: add #14241 * Changelog: add #14249 * Changelog: add #14264 * Changelog: add #14263 * Changelog: add #14256 * Changelog: add #10189 * Changelog: add #14240 * Changelog: add #14239 Also added some new entries to the testing file. Co-authored-by: Igor Zinovyev <[email protected]>

ChaosExAnima added [Status] Needs Review This PR is ready for review. Admin Page React-powered dashboard under the Jetpack menu [Feature] Backups labels Dec 10, 2019

ChaosExAnima added this to the 8.1 milestone Dec 10, 2019

ChaosExAnima requested review from a team December 10, 2019 20:46

ChaosExAnima self-assigned this Dec 10, 2019

jeherve requested changes Dec 10, 2019

View reviewed changes

jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. Plans and removed [Status] Needs Review This PR is ready for review. labels Dec 10, 2019

ChaosExAnima requested review from jeherve and tyxla December 11, 2019 20:26

ChaosExAnima added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Dec 11, 2019

ChaosExAnima mentioned this pull request Dec 11, 2019

Update product card options alignment and appearance Automattic/wp-calypso#38344

Merged

delawski reviewed Dec 12, 2019

View reviewed changes

tyxla reviewed Dec 12, 2019

View reviewed changes

tyxla added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Dec 12, 2019

ChaosExAnima force-pushed the update/launch-price-ux branch from 8b9ab85 to b5fbcb7 Compare December 12, 2019 20:23

delawski reviewed Dec 13, 2019

View reviewed changes

_inc/client/plans/single-product-backup.jsx Outdated Show resolved Hide resolved

ChaosExAnima force-pushed the update/launch-price-ux branch from f36b1d0 to b35dd10 Compare December 13, 2019 19:15

matticbot added the Touches WP.com Files label Dec 13, 2019

ChaosExAnima added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Dec 13, 2019

delawski added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Dec 17, 2019

tyxla added 4 commits December 17, 2019 11:16

Extract billing timeframe logic to a function

cc98b3e

Add a clarification for the missing arg in the localized string

aff60c1

Use CSS instead of em tag to make savings italic

84426b6

Left-align the promo header

af11003

tyxla added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Dec 17, 2019

Make ProductSavings self-sufficient

50e28fd

delawski previously approved these changes Dec 17, 2019

View reviewed changes

delawski requested a review from tyxla December 17, 2019 09:45

delawski added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 17, 2019

Add some space below promo section

dbe2478

tyxla dismissed delawski’s stale review via dbe2478 December 17, 2019 09:50

tyxla approved these changes Dec 17, 2019

View reviewed changes

delawski approved these changes Dec 17, 2019

View reviewed changes

jeherve approved these changes Dec 17, 2019

View reviewed changes

tyxla merged commit ed275e2 into master Dec 17, 2019

tyxla deleted the update/launch-price-ux branch December 17, 2019 10:02

matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 17, 2019

jeherve added [Status] Has Changelog and removed [Status] Needs Changelog labels Dec 20, 2019

jeherve added a commit that referenced this pull request Dec 20, 2019

Changelog: add #14203

8f5ee57

Updates Backup launch price UX #14203

Updates Backup launch price UX #14203

Uh oh!

Conversation

ChaosExAnima commented Dec 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this Pull Request:

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Testing instructions:

Proposed changelog entry for your changes:

Uh oh!

jetpackbot commented Dec 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChaosExAnima commented Dec 11, 2019

Uh oh!

delawski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tyxla left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChaosExAnima commented Dec 12, 2019

Uh oh!

Uh oh!

matticbot commented Dec 13, 2019

Uh oh!

delawski commented Dec 17, 2019

Uh oh!

tyxla commented Dec 17, 2019

Uh oh!

delawski left a comment

Choose a reason for hiding this comment

Uh oh!

tyxla left a comment

Choose a reason for hiding this comment

Uh oh!

delawski commented Dec 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ChaosExAnima commented Dec 10, 2019 •

edited

Loading

jetpackbot commented Dec 10, 2019 •

edited

Loading