Skip to content

E2E Tests: Add Jetpack updater test #16437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brbrr merged 46 commits into from
Aug 3, 2020
Merged

E2E Tests: Add Jetpack updater test #16437

brbrr merged 46 commits into from
Aug 3, 2020

Conversation

@brbrr
Copy link
Contributor

@brbrr brbrr commented Jul 8, 2020 •
edited
Loading

Adds a plugin updater test that should test plugin updates

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

  • Make sure the Travis is green

Proposed changelog entry for your changes:

  • n/a

@brbrr brbrr self-assigned this Jul 8, 2020
@jetpackbot
Copy link
Collaborator

jetpackbot commented Jul 8, 2020 •
edited
Loading

Warnings
⚠️

pre-commit hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16437

Generated by 🚫 dangerJS against 3a0a35c

@brbrr brbrr added Actions GitHub actions used to automate some of the work around releases and repository management [Feature] Activity Log and removed Actions GitHub actions used to automate some of the work around releases and repository management [Feature] Activity Log labels Jul 8, 2020
@brbrr brbrr requested review from a team and georgestephanis as code owners July 15, 2020 16:48
@brbrr brbrr force-pushed the try/e2e-jetpack-updater branch from 395d183 to cbaa9db Compare July 15, 2020 17:03
@brbrr brbrr removed request for a team and georgestephanis July 15, 2020 17:06
@brbrr brbrr force-pushed the try/e2e-jetpack-updater branch 2 times, most recently from 2fc8de4 to 4e5dc9d Compare July 22, 2020 07:20
@brbrr brbrr added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jul 23, 2020
@jeherve
Copy link
Member

jeherve commented Jul 24, 2020

Rebasing to fix unrelated test failures.

@jeherve jeherve force-pushed the try/e2e-jetpack-updater branch from 16dabb1 to 5edecc6 Compare July 24, 2020 17:20
@jeherve jeherve added this to the 8.8 milestone Jul 24, 2020
@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Jul 24, 2020
jeherve
jeherve requested changes Jul 24, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have a linting error:

tests/e2e/lib/pages/wp-admin/plugins.js
  6:10  error  'execShellCommand' is defined but never used  no-unused-vars

@brbrr brbrr force-pushed the try/e2e-jetpack-updater branch from 5edecc6 to 7ef98ec Compare July 27, 2020 15:22
@brbrr brbrr removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 27, 2020
@brbrr brbrr force-pushed the try/e2e-jetpack-updater branch from 6c9f5b2 to 3a0a35c Compare July 29, 2020 08:59
@brbrr brbrr added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jul 29, 2020
jeherve
jeherve approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing 🎉

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Aug 3, 2020
@brbrr brbrr merged commit 7aed4db into master Aug 3, 2020
@brbrr brbrr deleted the try/e2e-jetpack-updater branch August 3, 2020 14:51
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 3, 2020
davidlonjon added a commit that referenced this pull request Aug 6, 2020
@davidlonjon
Merge branch 'add/jetpack-lazy-images-package' of github.com:Automatt…
cc0cf00 
…ic/jetpack into add/jetpack-lazy-images-package

* 'add/jetpack-lazy-images-package' of github.com:Automattic/jetpack: (40 commits)
  Lodash: Revert to previous version (#16735)
  New class to handle async XML-RPC requests (#16674)
  Social Previews: Sidebar design updates (#16725)
  Update E2E locator for classic connection flow (#16708)
  Woo Services: update to use existing Jetpack plugin install tools (#16672)
  Admin Page: avoid blank dashboard when notice is not a string (#16721)
  Admin Page: update string still using old i18n format (#16722)
  Social Previews: Add sidebar UI (#16633)
  Fix recurring payments block disconnecting (sometimes) when existing article is reopened in block editor. (#16640)
  Connection Register: Add current user email to connection register request (#16712)
  Update versions to start 8.9 Release cycle (#16706)
  Donations block: Make currency and amounts editable (#16593)
  Update dependency @automattic/calypso-color-schemes to v2
  Error Notice: removing HTML code, adjusting maximum width. (#16690)
  Update dependency swiper to v6 (#16587)
  Site Scan: Short-circuit update_threats_link() if Admin Bar is not present (#16677)
  Update vulnerable NPM packages (#16659)
  E2E Tests: Add Jetpack updater test (#16437)
  check for subdir site before rendering Ads.txt section (#16671)
  VideoPress Block: Retain alignment support (#16651)
  ...
pereirinha pushed a commit that referenced this pull request Sep 10, 2020
@brbrr
[not verified] E2E Tests: Add Jetpack updater test (#16437)
6d7c9e6 
* [not verified] test file serving from travis CI

* [not verified] Add prep script and plugin updater plugin

* [not verified] cleanup stuff

* [not verified] Add plugin updater test

* [not verified] update CI environment setup script

* [not verified] figuring my way with bash

* [not verified] keep going

* [not verified] keep going pt2

* [not verified] .

* [not verified] get rid of includes functions in cli-prep script

* [not verified] cleanup

* [not verified] conditionally use `sudo`

* [not verified] .

* [not verified] try this

* [not verified] .

* [not verified] conditionally set dynamic siteurl

* [not verified] do it properly

* [not verified] cleanup

* [not verified] add new plugin into requirelist

* [not verified] fix linting

* [not verified] .

* [not verified] .

* [not verified] enable logging into console

* [not verified] .

* [not verified] yo

* [not verified] .

* [not verified] run updater preparation only for specific test

* maybe this will work

* .

* uninstall jetpack-dev plugin

* .

* .

* .

* .

* try something else

* exculde plugin-updater test from latest gutenberg job

* try removing the plugin

* im not sure what I'm doing

* .

* cleanup

* disable stdout logging in CI

* decrease timeout

* fix linting error

* catch allure attachment failures

* try to fix mailchimp test flakiness

* Update plugin updater test to use wp-env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@brbrr brbrr

Labels

E2E Tests

Projects

None yet

Milestone

8.9

Development

Successfully merging this pull request may close these issues.

5 participants

@brbrr @jetpackbot @jeherve @matticbot