Admin Page: avoid blank dashboard when notice is not a string #16721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up of #16690 The contents of the dashboard notices is not always a string. It can be a React element. When that's the case, let's avoid any errors by not using the replace method which is only available for strings.
jeherve
added
[Type] Bug
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16721 Scheduled Jetpack release: September 1, 2020. |
brbrr
approved these changes
Aug 5, 2020
Contributor
brbrr
left a comment
brbrr
left a comment
There was a problem hiding this comment.
At first, I saw the original error and compiled JS has not included changes from this PR. After hard reload it worked like a charm
brbrr
added
[Status] Ready to Merge
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
Member
Author
|
Cherry-picked to |
davidlonjon
added a commit
that referenced
this pull request
Aug 6, 2020
…ic/jetpack into add/jetpack-lazy-images-package * 'add/jetpack-lazy-images-package' of github.com:Automattic/jetpack: (40 commits) Lodash: Revert to previous version (#16735) New class to handle async XML-RPC requests (#16674) Social Previews: Sidebar design updates (#16725) Update E2E locator for classic connection flow (#16708) Woo Services: update to use existing Jetpack plugin install tools (#16672) Admin Page: avoid blank dashboard when notice is not a string (#16721) Admin Page: update string still using old i18n format (#16722) Social Previews: Add sidebar UI (#16633) Fix recurring payments block disconnecting (sometimes) when existing article is reopened in block editor. (#16640) Connection Register: Add current user email to connection register request (#16712) Update versions to start 8.9 Release cycle (#16706) Donations block: Make currency and amounts editable (#16593) Update dependency @automattic/calypso-color-schemes to v2 Error Notice: removing HTML code, adjusting maximum width. (#16690) Update dependency swiper to v6 (#16587) Site Scan: Short-circuit update_threats_link() if Admin Bar is not present (#16677) Update vulnerable NPM packages (#16659) E2E Tests: Add Jetpack updater test (#16437) check for subdir site before rendering Ads.txt section (#16671) VideoPress Block: Retain alignment support (#16651) ...
netsuso
pushed a commit
to Automattic/vip-go-mu-plugins
that referenced
this pull request
Aug 6, 2020
…roblem It includes this PR: Automattic/jetpack#16721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
The contents of the dashboard notices is not always a string. It can be a React element.
When that's the case, let's avoid any errors by not using the replace method which is only available for strings.
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
jetpack/_inc/client/components/jetpack-notices/index.jsx
Line 155 in 4392a22
react-dom.min.js?ver=16.9.0:103 TypeError: e.replace is not a functionProposed changelog entry for your changes: