Error Notice: removing HTML code, adjusting maximum width.

[sergeymitr]

The notice content should not contain HTML. If it happens to have any, we clear out the tags before displaying the error.

Changes proposed in this Pull Request:

• Removing HTML tags from the error text.
• Limiting the maximum width of the notice.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

1. Open your theme's functions.php and add following code to display the connection error notice:

add_filter( 'react_connection_errors_initial_state', function( $errors ) {
	$errors[] = array(
		'message' => __('Connection Error'),
		'action' => 'reconnect',
		'code' => 'invalid_blog_token',
	);

	return $errors;
} );

2. Open file packages/connection/src/class-rest-connector.php and add this line into the beginning of the connection_reconnect() method:

return rest_ensure_response( new WP_Error( 'some_error', str_repeat( ' something something <strong>HTML</strong> something something', 100 ) ) );

3. Open the Jetpack Dashboard, and click "Restore Connection" in the Connection Error notice. You should see the lots of repeated lines: something something HTML something something
4. Make sure there are no HTML tags in the notice text.
5. Confirm that the message has reasonable margin from the left sidebar, and doesn't hide behind it.

Before:

After:

Proposed changelog entry for your changes:

N/a.

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16690

Scheduled Jetpack release: August 4, 2020.
Scheduled code freeze: July 28, 2020

Generated by 🚫 dangerJS against 9a10ee6

[dereksmart]

@sergeymitr This seems to hide the dismiss button in my testing

Edit: It's because there was no space after stripping the HTML :) I don't think we'll ever see a long string like this without spaces, so may not be a problem.

[eeeeevon13]

Looks good to me!

[dereksmart]

Tests well for me

[jeherve]

Cherry-picked to branch-8.8 in 7c16820