Skip to content

Increase the editor.MediaUpload hook priority #16669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeherve merged 1 commit into from
Aug 12, 2020
Merged

Increase the editor.MediaUpload hook priority #16669

jeherve merged 1 commit into from
Aug 12, 2020

Conversation

@ravichdev
Copy link
Contributor

@ravichdev ravichdev commented Jul 31, 2020 •
edited by jeherve
Loading

Fixes #16668

Changes proposed in this Pull Request:

  • Let's change the priority at which we hook our External Media implementation into the existing media library. That will avoid conflicts with other plugins that do the same.

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Go to Posts > Add New
  • Add an image block
  • Select Google Photos or Pexels in the options to pick an existing image
  • It should still work

Proposed changelog entry for your changes:

  • Block Editor: ensure our External Media option is compatible with other plugins that also make changes to the Media Library options in the block editor.

@jetpackbot
Copy link
Collaborator

jetpackbot commented Jul 31, 2020

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16669

Generated by 🚫 dangerJS against e62c2cb

@jeherve jeherve added [Extension] External Media Extend all block editor media tools to support external providers [Pri] Normal [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Jul 31, 2020
@jeherve jeherve added this to the 8.9 milestone Jul 31, 2020
retrofox
retrofox reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@retrofox retrofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ravichdev for your suggestion.
I don't see any problem with increasing the priority here. @marekhrabe do you have some objection here?

@jeherve jeherve self-assigned this Aug 12, 2020
@jeherve
Copy link
Member

jeherve commented Aug 12, 2020

Internal reference: D48011-code

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Aug 12, 2020
@jeherve jeherve merged commit f2a1416 into Automattic:master Aug 12, 2020
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 12, 2020
@jeherve
Copy link
Member

jeherve commented Aug 12, 2020

r212052-wpcom

davidlonjon added a commit that referenced this pull request Aug 14, 2020
@davidlonjon
Merge branch 'master' into add/jetpack-lazy-images-package
e169b52 
* master: (41 commits)
  use blog token to make the request (#16635)
  External Media: Add account disconnect button (#16759)
  CI: Try collect js coverage (#16786)
  Sync: Fix nonce action string in theme edit sync (#16702)
  Connect-in-place: hide new heading during connection process (#16703)
  Update dependency eslint-plugin-jsdoc to v30.2.1 (#16765)
  Theme Tools: Resolve PHP 7.4 array offset notice. (#16795)
  New shell command for easier access to the database. (#16761)
  My Plan: Add Offer Reset project new plans (Jetpack Security, Jetpack Complete) (#16739)
  Increase the `editor.MediaUpload` hook priority (#16669)
  External Media: Remove `speak` announcement when inserting media.
  Extensions: make `render_callback` optional when checking block registration against plan (#16746)
  Conditional check for wrapper before giving focus to new page (#16817)
  Docker: Add package testing shortcut (#16810)
  Settings: Recognize valid Akismet keys from wp-config and restrict input (#16542)
  Social Previews: Add Modal (#16704)
  Update dependency preact to v10.4.7 (#16768)
  Improve a11y of amp-social-share (#16737)
  Instant Search: Tweak expanded result path styling (#16762)
  Docker: Add phpmyadmin to the docker-composer.yml (#16806)
  ...
jeherve added a commit that referenced this pull request Aug 25, 2020
@jeherve
Changelog: add #16669
2aef45f
pereirinha pushed a commit that referenced this pull request Sep 10, 2020
@ravichdev
[not verified] Increase the editor.MediaUpload hook priority (#16669)
51bc7bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@retrofox retrofox retrofox left review comments

@jeherve jeherve jeherve approved these changes

Assignees

@jeherve jeherve

Labels

[Extension] External Media Extend all block editor media tools to support external providers [Pri] Normal Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

8.9

Development

Successfully merging this pull request may close these issues.

Increase priority for editor.MediaUpload filter

5 participants

@ravichdev @jetpackbot @jeherve @retrofox @matticbot