Connect-in-place: hide new heading during connection process #16703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #16643, we updated the design of the connection panel and added a new heading at the bottom of the page. Let's ensure that heading disappears with the rest of the content when you start the connection process.
jeherve
added
[Type] Bug
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16703 Scheduled Jetpack release: September 1, 2020. |
sergeymitr
approved these changes
Aug 4, 2020
Contributor
sergeymitr
left a comment
sergeymitr
left a comment
There was a problem hiding this comment.
Works well.
Also tested in secondary connection flow, and the "Restore Connection", no issues.
I'm leaving the "Needs Review" label as there are other reviewers, please adjust labels yourself if needed.
matticbot
added
[Status] Needs Changelog
and removed
[Status] Needs Review
davidlonjon
added a commit
that referenced
this pull request
Aug 14, 2020
* master: (41 commits) use blog token to make the request (#16635) External Media: Add account disconnect button (#16759) CI: Try collect js coverage (#16786) Sync: Fix nonce action string in theme edit sync (#16702) Connect-in-place: hide new heading during connection process (#16703) Update dependency eslint-plugin-jsdoc to v30.2.1 (#16765) Theme Tools: Resolve PHP 7.4 array offset notice. (#16795) New shell command for easier access to the database. (#16761) My Plan: Add Offer Reset project new plans (Jetpack Security, Jetpack Complete) (#16739) Increase the `editor.MediaUpload` hook priority (#16669) External Media: Remove `speak` announcement when inserting media. Extensions: make `render_callback` optional when checking block registration against plan (#16746) Conditional check for wrapper before giving focus to new page (#16817) Docker: Add package testing shortcut (#16810) Settings: Recognize valid Akismet keys from wp-config and restrict input (#16542) Social Previews: Add Modal (#16704) Update dependency preact to v10.4.7 (#16768) Improve a11y of amp-social-share (#16737) Instant Search: Tweak expanded result path styling (#16762) Docker: Add phpmyadmin to the docker-composer.yml (#16806) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
In #16643, we updated the design of the connection panel and added a new heading at the bottom of the page.
Let's ensure that heading disappears with the rest of the content when you start the connection process.
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Proposed changelog entry for your changes: