Skip to content

Infinite Scroll: Fix bug condition where no wrapper is present #16817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scottsweb merged 1 commit into from
Aug 12, 2020
Merged

Infinite Scroll: Fix bug condition where no wrapper is present #16817

scottsweb merged 1 commit into from
Aug 12, 2020

Conversation

@scottsweb
Copy link
Contributor

@scottsweb scottsweb commented Aug 12, 2020

Conditional check for wrapper before giving focus to new page.

Fixes #16807

Changes proposed in this Pull Request:

  • Bug fix, add small conditional

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

N/A

Testing instructions:

  • Make sure Jetpack 8.8 or Jetpack 8.8.1 is installed and activated
  • Activate a Theme with Support for Infinite Scroll with the following settings: 'type' => 'click', 'wrapper' => false,
  • Go to the Dashboard > Jetpack > Settings > Writing
  • Scroll down to 'Theme enhancements' > 'Infinite Scroll'
  • Check 'Load more posts in page with a button' and click 'Save settings'
  • Switch to the front end of the site and go to the blog page
  • Scroll down to and click the 'Load more' button ( Make sure the site has enough posts for the Infinite Scroll button to be visible )
  • Check for JS errors and that the load more button continues to work

Proposed changelog entry for your changes:

  • N/A

@scottsweb scottsweb added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Infinite Scroll labels Aug 12, 2020
@scottsweb scottsweb requested a review from jeherve August 12, 2020 10:05
@scottsweb scottsweb self-assigned this Aug 12, 2020
@scottsweb scottsweb mentioned this pull request Aug 12, 2020
Closed
@jetpackbot
Copy link
Collaborator

jetpackbot commented Aug 12, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16817

Scheduled Jetpack release: September 1, 2020.
Scheduled code freeze: August 25, 2020

Generated by 🚫 dangerJS against 1e1a18f

@scottsweb scottsweb added the [Status] Needs Review This PR is ready for review. label Aug 12, 2020
@jeherve jeherve added this to the 8.9 milestone Aug 12, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Aug 12, 2020
jeherve
jeherve approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me.

@jeherve
Copy link
Member

jeherve commented Aug 12, 2020

Noting that you should now be able to add those changes to D45833-code before you commit it.

@scottsweb scottsweb merged commit 085e295 into master Aug 12, 2020
@scottsweb scottsweb deleted the fix/16807-support-no-wrapper-infinite-scroll branch August 12, 2020 13:39
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 12, 2020
@eduardozulian
Copy link
Member

eduardozulian commented Aug 13, 2020

Reported by a WordPress.com user:

  • Theme: Dyad 1 and 2
  • 3219920-zen

@matticbot matticbot added the Customer Report [LEGACY] Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Aug 13, 2020
@sashastone
Copy link

sashastone commented Aug 13, 2020

Reported by a WordPress.com user:

  • Theme: Veni
  • 3215787-zen

@lizswafford
Copy link

lizswafford commented Aug 13, 2020

Reported by a WordPress.com user:

Theme: Morden
3222106-zen

@jordesign
Copy link
Contributor

jordesign commented Aug 13, 2020

Reported by another user:

Theme: Argent
3223273-zen

davidlonjon added a commit that referenced this pull request Aug 14, 2020
@davidlonjon
Merge branch 'master' into add/jetpack-lazy-images-package
e169b52 
* master: (41 commits)
  use blog token to make the request (#16635)
  External Media: Add account disconnect button (#16759)
  CI: Try collect js coverage (#16786)
  Sync: Fix nonce action string in theme edit sync (#16702)
  Connect-in-place: hide new heading during connection process (#16703)
  Update dependency eslint-plugin-jsdoc to v30.2.1 (#16765)
  Theme Tools: Resolve PHP 7.4 array offset notice. (#16795)
  New shell command for easier access to the database. (#16761)
  My Plan: Add Offer Reset project new plans (Jetpack Security, Jetpack Complete) (#16739)
  Increase the `editor.MediaUpload` hook priority (#16669)
  External Media: Remove `speak` announcement when inserting media.
  Extensions: make `render_callback` optional when checking block registration against plan (#16746)
  Conditional check for wrapper before giving focus to new page (#16817)
  Docker: Add package testing shortcut (#16810)
  Settings: Recognize valid Akismet keys from wp-config and restrict input (#16542)
  Social Previews: Add Modal (#16704)
  Update dependency preact to v10.4.7 (#16768)
  Improve a11y of amp-social-share (#16737)
  Instant Search: Tweak expanded result path styling (#16762)
  Docker: Add phpmyadmin to the docker-composer.yml (#16806)
  ...
@jjchrisdiehl
Copy link

jjchrisdiehl commented Aug 14, 2020

WordPress.com user

Theme: Dyad 2
23355855-hc

@jeherve jeherve modified the milestones: 8.9, 8.8.2 Aug 14, 2020
jeherve pushed a commit that referenced this pull request Aug 14, 2020
@scottsweb @jeherve
[not verified] Conditional check for wrapper before giving focus to n…
0e168b9 
…ew page (#16817)
@jeherve
Copy link
Member

jeherve commented Aug 14, 2020

Cherry-picked to branch-8.8 in 0e168b9

@jeherve jeherve mentioned this pull request Aug 14, 2020
Merged
@dcoleonline
Copy link

dcoleonline commented Aug 20, 2020 •
edited
Loading

Theme: aquene
3243987-zen

The customer would like an update once this is resolved.

@scottsweb
Copy link
Contributor Author

scottsweb commented Aug 21, 2020

@dcoleonline it is resolved in Jetpack 8.8.2, can the customer confirm they have updated?

@eduardozulian
Copy link
Member

eduardozulian commented Aug 21, 2020

I have notified all the users listed here.

Thanks for the fix!

pereirinha pushed a commit that referenced this pull request Sep 10, 2020
@scottsweb
[not verified] Conditional check for wrapper before giving focus to n…
e89b04b 
…ew page (#16817)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@scottsweb scottsweb

Labels

Customer Report [LEGACY] Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Infinite Scroll Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Milestone

8.8.2

Development

Successfully merging this pull request may close these issues.

Infinite Scroll: Jetpack 8.8 breaks Infinite Scroll with type:'click' and wrapper:'false'