Skip to content

Protect Meets Core: Project Branch #40191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nateweller wants to merge 54 commits into from
Closed

Protect Meets Core: Project Branch #40191

nateweller wants to merge 54 commits into from

Conversation

@nateweller
Copy link
Contributor

@nateweller nateweller commented Nov 14, 2024 •
edited
Loading

Project branch for the "Core in Protect" project.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

peb6dq-31T-p2

Does this pull request change what data or activity we track or use?

TBD

Testing instructions:

  • TBD

@nateweller nateweller requested a review from a team November 14, 2024 18:17
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. label Nov 14, 2024
@nateweller nateweller force-pushed the add/protect/core branch 3 times, most recently from fb3582e to dcefb9a Compare November 25, 2024 22:20
@nateweller nateweller changed the base branch from trunk to fix/scan/build November 25, 2024 22:20
Base automatically changed from fix/scan/build to trunk November 26, 2024 17:19
@nateweller nateweller force-pushed the add/protect/core branch 4 times, most recently from 4dea670 to 5656dbe Compare December 2, 2024 17:20
@nateweller nateweller force-pushed the add/protect/core branch 2 times, most recently from 293564e to a5a6565 Compare December 4, 2024 21:11
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/protect/core branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/protect/core

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/protect/core

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@nateweller nateweller force-pushed the add/protect/core branch 9 times, most recently from cfebba4 to 322819d Compare December 11, 2024 18:18
dkmyta and others added 26 commits March 22, 2025 12:38
@dkmyta @nateweller
ThreatsDataViews: Improve responsiveness (#40670)
aa5b2a3 
* Init project branch

* Init project branch

* Improve component responsiveness

* Init project branch

* Fix merge conflict

* Simplify, and only default to list view in mobile

* Fix spacing

* Minor adjustments to initialization of defaultLayouts, remove memo

* Remove style overrides on core component

* Reapply min-width for ScanToggleGroupControl

---------

Co-authored-by: Nate Weller <[email protected]>
@dkmyta @nateweller
ThreatsDataViews: ThreatModal integration (#40202)
193070d
@nateweller
Protect Meets Core: Fix "0" rendered by conditional render chain (#40882
5eda38e 
)
@nateweller
Fix: add missing return
3af8b55
@nateweller
Fix: reduce of empty array with no initial value
c24ad4d
@nateweller
Fix: hide home report when first protect report scan initializing
94010c9
@nateweller
minor adjustments
6b592a9
@nateweller
Update lockfile
149ae4c
@nateweller
Remove changes to protect-status package
eb000c5
@nateweller
Remove changes to badge components, moved to #41450
35f474d
@nateweller
Fix type error
b368b68
@nateweller
Fix stories
556e0f5
@nateweller
Fix case where status.core is empty
4a8d00b
@nateweller
Spacing and sizing adjustments
6f73041
@nateweller
Restore unintended webpack-cli version change
5f2b0e8
@nateweller
Fix ThreatsDataViews test
4953bd8
@nateweller
changelog
d3e68cf
@nateweller
Fix width of hero content
138753d
@nateweller
Improve threat ignore/unignore queries
c03770c
@nateweller
Remove close button from threat details modal actions
dc202f0
@nateweller
Remove unneccessary changes to protect-status package
fa36e2b
@nateweller
Fix z-index conflict between Notice and DataViews components
37fc1a0
@nateweller
Fix ThreatsDataViews title line wrapping
1776bd1
@nateweller
Add alternate 'how to fix it' message when no fixer or fixed in versi…
332009e 
…on available
@nateweller
Fix imports and enhance types
c44edb1
@nateweller
Additional import fixes and type improvements
aa98338
@nateweller nateweller mentioned this pull request Mar 22, 2025
Closed
3 tasks
@nateweller nateweller closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anomiex anomiex anomiex left review comments

Assignees

@nateweller nateweller

@dkmyta dkmyta

Labels

[JS Package] Components [JS Package] Scan [Package] Protect Status [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. RNA [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nateweller @anomiex @dkmyta