Skip to content

Protect Meets Core #42664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nateweller wants to merge 3 commits into from
Closed

Protect Meets Core #42664

nateweller wants to merge 3 commits into from

Conversation

@nateweller
Copy link
Contributor

@nateweller nateweller commented Mar 22, 2025

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@github-actions github-actions bot added [JS Package] Components [JS Package] Scan [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress [Tests] Includes Tests RNA labels Mar 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Protect plugin:

  • Next scheduled release: April 1, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/protect/core-3 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/protect/core-3

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/protect/core-3

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jp-launch-control
Copy link

jp-launch-control bot commented Mar 22, 2025 •
edited
Loading

Code Coverage Summary

No summary data is available for parent commit c403999, so cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for c403999 is available.

Full summary · PHP report · JS report

@nateweller nateweller force-pushed the add/scan/protect-meets-core-components branch 2 times, most recently from df7e741 to 1a48f99 Compare March 25, 2025 21:30
@nateweller nateweller force-pushed the add/scan/protect-meets-core-components branch 2 times, most recently from 79f3429 to 8832648 Compare March 29, 2025 18:28
@nateweller nateweller force-pushed the add/scan/protect-meets-core-components branch from 8832648 to c403999 Compare March 29, 2025 23:45
nateweller and others added 2 commits March 30, 2025 17:34
@nateweller
Protect Meets Core
af4505e 
Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057)
Protect: Update Scan and History headers (#40058)
Protect: de-emphasize cloud link by using link variant (#40211)
Protect: Add ShieldIcon Component (#40402)
Protect: Integrate ThreatsDataViews Component (#40076)
Components: Add ScanReport (#40419)
Protect: Refactor AdminSectionHero (#40516)
Protect: Update Scan History extension types (#40548)
Protect: Add Home page (#40317)
Protect: Integrate ScanReport (#40420)
ScanReport: Fix defaultLayout (#40603)
Update onboarding popover placement (#40550)
Protect Meets Core: Home Page Scan Report Data Adjustments (#40616)
Scan Report: Align Status Icon (#40617)
Apply max width to hero content (#40618)
Protect: Hide Scan Report When No Data (#40619)
Protect: Hide Threats Report When No Data (#40620)
Protect: Update Threat Icons (#40621)
Protect: fix home page stat card spacing (#40623)
ScanReport: Disable hiding relevant fields (#40602)
Use error variant (#40832)
Protect: Restore HistoryAdminSectionHero (#40551)
Protect: Separate scan results and history DataViews (#40845)
ThreatsDataViews: Improve responsiveness (#40670)
ThreatsDataViews: ThreatModal integration (#40202)
Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)
@nateweller
Protect Components: Use @wordpress/dataviews/wp import path (#41510)
ea5282d
@nateweller nateweller closed this Apr 2, 2025
@github-actions github-actions bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

[Feature] Publicize Now Jetpack Social, auto-sharing [JS Package] Components [JS Package] Publicize Components [JS Package] Scan [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. RNA [Tests] Includes Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nateweller