ThreatsDataViews: Improve responsiveness

[dkmyta]

Description

Ensure the ThreatsDataViews component appropriately handles various view ports.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

• https://github.com/Automattic/jetpack-scan-team/issues/1597

Does this pull request change what data or activity we track or use?

• No

Testing instructions:

• Review ThreatsDataViews storybooks and ensure no regressions are introduced
• Checkout this Protect branch on Jurassic Tube/Ninja
• View the ScanReport and ScanResultsDataViews in varying screen sizes and ensure the search, filter and toggle actions and the table all respond correctly and the content is appropriately spaced out, or scrollable
• When viewing the ScanResultsDataViews component in mobile (max-width: 599px), ensure that the component defaults to list view.

Screenshots

ScanResultsDataViews:

ScanReport:

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/components/threats-data-views-responsiveness branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/components/threats-data-views-responsiveness
  

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/components/threats-data-views-responsiveness
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• 🔴 Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

🔴 Action required: Please add missing changelog entries for the following projects: projects/js-packages/components, projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Protect plugin:

• Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[nateweller]

Is it necessary to prevent mobile users from accessing the table layout like this? It would be nice if we could default the view to list on mobile, but still keep it accessible.

Then we would only need to worry about setting the list vs table layout on first render:

const [view, setView] = useState( isSm ? listView : tableView )

Assuming isSm works out of the box without a re-render. Otherwise we could use the window directly.

Anyways, all IMO.

[dkmyta]

Is it necessary to prevent mobile users from accessing the table layout like this? It would be nice if we could default the view to list on mobile, but still keep it accessible.

Ah my apologies, I must have misunderstood - I was under the impression we wanted to force list view but defaulting and allowing users to switch to table view makes sense to me, will adjust 👍🏻

[dkmyta]

Assuming isSm works out of the box without a re-render. Otherwise we could use the window directly.

@nateweller Out of curiosity, ideally how would you expect this function? Using just useBreakpointMatch might be fine, it does require a re-render but maybe thats not an issue. For instance, if I am in table view in full screen and shrink my screen to the trigger point, would I really want the UI to update to list view (and vice-versa). Maybe its okay just have the default on re-render which strictly apply to mobile users. Happy to look in to the window approach, just thought I'd run it by you first. Here's the first take - 2f5e469

Also noting that with the addition of the extra settings toggle in the header, things are now a little squished:

What do you think if we adding alternate styling/content for mobile for the ToggleGroupControl? Perhaps:

Noting that we may need to take the window approach if we go that route.

[nateweller]

Made some minor adjustments, LGTM 👍

[dkmyta]

@nateweller The core styling override that was removed in 2494779 accounts for this issue:

Before:

After:

Perhaps there is a better approach that avoids needing the override?

[nateweller]

Perhaps there is a better approach that avoids needing the override?

@dkmyta I've been strongly advised to avoid overriding the core components as much as possible, to prevent styles from breaking on a version update where the layout/classes/styles may change in the core component. Especially with DataViews being a less mature component, things can change often.

I think the alternative approach would be to apply custom styles to our own component that we are inserting into the header there in the first place. For example, reducing the status toggle's size on mobile by shortening the labels or using icons.