Unpin wheel version, update CI check #1462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
2 tasks
| inputs: | ||
| versionSpec: 3.6 | ||
| - bash: pip install wheel==0.30.0 pylint==1.9.5 flake8==3.5.0 requests | ||
| - bash: pip install wheel pylint==1.9.5 flake8==3.5.0 requests pkginfo |
Member
There was a problem hiding this comment.
Not considering breaking change versions for wheel and pkginfo?
Contributor
Author
There was a problem hiding this comment.
As for wheel, I am not wrong about the breaking change unless the PEP related the Python Package. The latest and unresolved PEP about this is PEP 491, but it seems won'
t introduce any breaking change, it's an enhancement.
As for pkginfo, I am a bit concerned about it, because it's onboard on Ubuntu Launch Code with little issues and invisible about the development activity.
So, if we relax the majon version of wheel and pkginfo can't keep up with the latest PEP version, that's a risk.
But considering the PEP process, it won't be a problem for a long while.
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=340888 Last commit: Azure@28e108d Co-authored-by: Feiyue Yu <[email protected]> Co-authored-by: Xiaojian Xu <[email protected]>
…eality everything before -hcp-, this fix helps clearing that confusion. (Azure#1451) * Presentation fix: The name displayed for the storage is inreality everything before -hcp-, this fix helps clearing that confusion. * Moving to helper + Test following existing pattern. * Pylint issue fixed. Co-authored-by: root <[email protected]> Co-authored-by: Feiyue Yu <[email protected]>
…#1494) Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=342289 Last commit: Azure@776c4a4 Co-authored-by: Jianhui Harold <[email protected]>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=343358 Last commit: Azure@a93d1db Co-authored-by: Jianhui Harold <[email protected]>
* [HPC-Cache] first version
* [HPC-Cache] test case fix
* refine test case
* {hpc-cache} Refine and test
* {hpc-cache} Fix style
* {hpc-cache} add experimental flag
* [HPC-Cache] fix comment
* Update CODEOWNERS
* {hpc-cache} fix the test file name
* {hpc-cache} add flush and upgrade commands
* {hpc-cache} add flush and upgrade commands help
* bump sdk * finish code * hack to fix python sdk * recording tests * fix style * bump sdk and versions * address comments * rename it to md * md * add experimental
* [Stream Analytics] add experimental tag
* {Stream Analytics} add isExperimental in metadata.json
Co-authored-by: Jianhui Harold <[email protected]>
* Support Databox in Azure CLI cmdlets
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=347136 Last commit: Azure@5e8de4e
…#1513) Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=347155 Last commit: Azure@ae26dd6 Co-authored-by: Xiaojian Xu <[email protected]>
) Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=347000 Last commit: Azure@6d21d72 Co-authored-by: MyronFanQiu <[email protected]>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=346985 Last commit: Azure@8c38351 Co-authored-by: qianwens <[email protected]>
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=347255 Last commit: Azure@73928e0 Co-authored-by: Yu Chen <[email protected]>
added 9 commits
June 19, 2020 13:11
…sions into unpin-wheel
haroldrandom
requested review from
Juliehzl,
YalinLi0312,
aim-for-better,
arrownj,
bquantump,
changlong-liu,
gtracer,
idear1203,
jsntcy,
kalyanaj,
mit2nil,
mmyyrroonn,
qianwens,
qwordy,
shahbj79,
wilcobmsft,
zhoxing-ms,
zikalino and
zqingqing1
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unpin wheel version as user request, deprecating old way to query metadata of Python Package.
Using pkginfo to query metadata for Python Package to meet Python Core Cetadata Specification. ( PEP 241, PEP 314, PEP 345, PEP 566).
What this PR done:
scripts/ci/aval-ext-doc/update_extension_list.pyscripts/ci/test_index.pyscripts/ci/test_source.pyazdev and Azure/azure-clihave already catch up to change:
Related PRs and issues:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.