Skip to content

Conversation

@vizhur
Copy link
Contributor

@vizhur vizhur commented Jan 9, 2025

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 9, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 9, 2025

Generated ApiView

Language Package Name ApiView Link
.Net Azure.ResourceManager.MachineLearning https://apiview.dev/Assemblies/Review/b3a1424a42c346a8906822f457909b53?revisionId=dd83439898ae420abf7810205dc2d42d

@razvanbadea-msft
Copy link
Member

same comments as for #32073. Abandon the previous one as i see it is a duplicate of this

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 10, 2025
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 10, 2025
@ZhidaLiu
Copy link
Member

/azp run

@openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@vizhur
Copy link
Contributor Author

vizhur commented Jan 10, 2025

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 32075 in repo Azure/azure-rest-api-specs

@ms-bogdan-rotaru
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ms-bogdan-rotaru
Copy link
Contributor

Please check the errors reported by failed checks.

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 13, 2025
@ZhidaLiu
Copy link
Member

The failed pipeline is not caused by the change in this PR and also not blocking the merge.

@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 13, 2025
@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 14, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 14, 2025
@ZhidaLiu ZhidaLiu merged commit 228d9b2 into Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2025-01-01-preview Jan 16, 2025
21 of 25 checks passed
ZhidaLiu pushed a commit that referenced this pull request Feb 10, 2025
* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json
ragovada added a commit that referenced this pull request Feb 14, 2025
…ices 2025 01 01 preview (#32541)

* Copy files from preview/2024-10-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-01-01-preview

Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview.

* Added tag for 2025-01-01-preview in readme file

* Making updates to ActualCapacityInfo for Inference Group Status (#32002)

* Add ActualCapacityInfo contract changes to 2025 preview

* Making updates to ActualCapacityInfo for Group Status

* Add quota apis to MFE 20250101-preview (#31885)

* Add quota apis

* add location in swagger

* add list available quota

* add AvailableQuotaArmPaginatedResult

* add location param

* location param in examples

* replace with location parameters

* Removes azure-resource-manager-schemas from SDK automation. It can be re-added without reverting this commit. (#30893) (#31918)

This change produces an extra warning but no obvious new errors.

---------

Co-authored-by: Daniel Jurek <[email protected]>

* Prettier Gate fixes for Jan 25 preview (#31864)

Co-authored-by: ZhidaLiu <[email protected]>

* [MFE][2025-01-01-preview] Add deferred safety to serverless endpoints (#32030)

* Update mfe.json to add new content safety level property

* prettier

* more prettier

* Update createOrUpdate.json with contentsafetylevel

* Update get.json

* Update list.json

* Update update.json

* Update EnvironmentVersion with vulnerabilities object (#32075)

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Add parent job name (#32106)

* add parent job name

add parent job name

* prettier

prettier

* prettier

prettier

* Correct tag format (#32141)

* [MFE] Add AAD Auth Modes to Serverless Endpoint (#32100)

* add aad auth mode and cherrypick

* prettier

* remove getStatus change

* reset mfe, add back aad auth

* revert getStatus

* prettier cmd

* update mfe

* prettier

* cherrypick commit 1fc2fa1

* add newline back

* add newline back

* Lint diff fixes for Jan 25 preview (#31939)

* Lint diff fixes for Jan 25 preview

* Update tag

* Keep tag format consistent with other versions

* resolve merge conflicts

---------

Co-authored-by: ZhidaLiu <[email protected]>

* Release distillation changes (#32186)

* Distillation ARM changes

* Fix CSPell check

* Fixed Prettier Failures

* Fixed Model Validation

* Updated PromptSetting description

* Added Only Distillation Changes

* Added definitions

* removed unwanted changes

* Ran Prettier

* Updated swagger based on Vienna review

* Updated Examples

* Updated Description for Prompt Setting

* Reorganized as per review comments

* Updated examples

* Ran Prettier

* Handled review comments

* Added Suppression.yaml file

* Updated syntax

* Fixed syntax

* Added Suppressions in readme

---------

Co-authored-by: Qiaoqiao Zhang <[email protected]>

* Fix typo in vuln contract (#32280)

* Add the property irewallPublicIpAddress in ManagedNetworkSettings (#32123)

* Fix issue caused by rebase

* updated mfe.json (#32543)

* add more suppression for lint diff error that we can't fix (#32603)

---------

Co-authored-by: ragovada <[email protected]>
Co-authored-by: ritujhams <[email protected]>
Co-authored-by: jingyizhu99 <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>
Co-authored-by: ragovada <[email protected]>
Co-authored-by: liangjason87 <[email protected]>
Co-authored-by: vizhur <[email protected]>
Co-authored-by: marici7274 <[email protected]>
Co-authored-by: Karishma Daga <[email protected]>
Co-authored-by: vikasagrawal-ms <[email protected]>
Co-authored-by: Qiaoqiao Zhang <[email protected]>
Co-authored-by: haoranqian <[email protected]>
Co-authored-by: sarajag <[email protected]>
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
…ices 2025 01 01 preview (Azure#32541)

* Copy files from preview/2024-10-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-01-01-preview

Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview.

* Added tag for 2025-01-01-preview in readme file

* Making updates to ActualCapacityInfo for Inference Group Status (Azure#32002)

* Add ActualCapacityInfo contract changes to 2025 preview

* Making updates to ActualCapacityInfo for Group Status

* Add quota apis to MFE 20250101-preview (Azure#31885)

* Add quota apis

* add location in swagger

* add list available quota

* add AvailableQuotaArmPaginatedResult

* add location param

* location param in examples

* replace with location parameters

* Removes azure-resource-manager-schemas from SDK automation. It can be re-added without reverting this commit. (Azure#30893) (Azure#31918)

This change produces an extra warning but no obvious new errors.

---------

Co-authored-by: Daniel Jurek <[email protected]>

* Prettier Gate fixes for Jan 25 preview (Azure#31864)

Co-authored-by: ZhidaLiu <[email protected]>

* [MFE][2025-01-01-preview] Add deferred safety to serverless endpoints (Azure#32030)

* Update mfe.json to add new content safety level property

* prettier

* more prettier

* Update createOrUpdate.json with contentsafetylevel

* Update get.json

* Update list.json

* Update update.json

* Update EnvironmentVersion with vulnerabilities object (Azure#32075)

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Add parent job name (Azure#32106)

* add parent job name

add parent job name

* prettier

prettier

* prettier

prettier

* Correct tag format (Azure#32141)

* [MFE] Add AAD Auth Modes to Serverless Endpoint (Azure#32100)

* add aad auth mode and cherrypick

* prettier

* remove getStatus change

* reset mfe, add back aad auth

* revert getStatus

* prettier cmd

* update mfe

* prettier

* cherrypick commit 1fc2fa1

* add newline back

* add newline back

* Lint diff fixes for Jan 25 preview (Azure#31939)

* Lint diff fixes for Jan 25 preview

* Update tag

* Keep tag format consistent with other versions

* resolve merge conflicts

---------

Co-authored-by: ZhidaLiu <[email protected]>

* Release distillation changes (Azure#32186)

* Distillation ARM changes

* Fix CSPell check

* Fixed Prettier Failures

* Fixed Model Validation

* Updated PromptSetting description

* Added Only Distillation Changes

* Added definitions

* removed unwanted changes

* Ran Prettier

* Updated swagger based on Vienna review

* Updated Examples

* Updated Description for Prompt Setting

* Reorganized as per review comments

* Updated examples

* Ran Prettier

* Handled review comments

* Added Suppression.yaml file

* Updated syntax

* Fixed syntax

* Added Suppressions in readme

---------

Co-authored-by: Qiaoqiao Zhang <[email protected]>

* Fix typo in vuln contract (Azure#32280)

* Add the property irewallPublicIpAddress in ManagedNetworkSettings (Azure#32123)

* Fix issue caused by rebase

* updated mfe.json (Azure#32543)

* add more suppression for lint diff error that we can't fix (Azure#32603)

---------

Co-authored-by: ragovada <[email protected]>
Co-authored-by: ritujhams <[email protected]>
Co-authored-by: jingyizhu99 <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>
Co-authored-by: ragovada <[email protected]>
Co-authored-by: liangjason87 <[email protected]>
Co-authored-by: vizhur <[email protected]>
Co-authored-by: marici7274 <[email protected]>
Co-authored-by: Karishma Daga <[email protected]>
Co-authored-by: vikasagrawal-ms <[email protected]>
Co-authored-by: Qiaoqiao Zhang <[email protected]>
Co-authored-by: haoranqian <[email protected]>
Co-authored-by: sarajag <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants