Skip to content

Conversation

@vikasagrawal-ms
Copy link
Member

@vikasagrawal-ms vikasagrawal-ms commented Jan 16, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    The Swagger LintDiff fails with the AvoidAdditionalProperties rule. However, this is necessary to allow users to specify custom inference parameters and fine-tuning hyperparameters for any model. Enforcing typecasting would require modifying contracts for each new addition by model providers. A similar approach has been previously permitted for the FinetuningJob.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

DistillationJob

This PR introduces a new job type called DistillationJob. In this job, a teacher model is used to prepare a dataset through inference, and a student model is fine-tuned on the prepared dataset. The DistillationJob is flexible and does not enforce fixed models, allowing users to select any model available in the Model Catalogue. These models, provided by third-party model providers, can include custom hyperparameters for fine-tuning and inference parameters as needed.

Suppressing failures

The Swagger LintDiff fails with the AvoidAdditionalProperties rule. However, this is necessary to allow users to specify custom inference parameters and fine-tuning hyperparameters for any model. Enforcing typecasting would require modifying contracts for each new addition by model providers. A similar approach has been previously permitted for the FinetuningJob.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 16, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jan 16, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/machinelearning/armmachinelearning There is no API change compared with the previous version
Java azure-resourcemanager-machinelearning https://apiview.dev/Assemblies/Review/e1c428cb12c840a2b15ad2ba61d138e7?revisionId=bdf4e899d8404480877b8cee85c03b98
JavaScript @azure/arm-machinelearning https://apiview.dev/Assemblies/Review/4b0822cc790d43b3b46bc9b075044246?revisionId=a7f75fcdc3d94aa5b30e2d826e9b2421

@vikasagrawal-ms
Copy link
Member Author

There are 3 gate failures
SDK azure-sdk-for-js: This is NOT related to my change
Swagger LintDiff: Fails with AvoidAdditionalProperties, but those are required to enable user to provide InferenceParameters and Hyperparameters for FT for any model. Typecasting would involve modification of contracts for any new addition by model providers. It has been allowed for Finetuning Job earlier
Automated merging requirements met : Waiting on Review and SwaggerLintDiff

…ngServices-2025-01-01-preview' into release-Distillation-changes
@qiaozha
Copy link
Member

qiaozha commented Jan 20, 2025

The JS failure should have been fixed.

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 24, 2025
@openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

…ngServices-2025-01-01-preview' into release-Distillation-changes
"type": "object",
"properties": {
"enableChainOfDensity": {
"type": "boolean"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"type": "boolean"

can this be modelled as an enum to make it extensible in future? same applicable to other properties under promptSettings?

Copy link

@pcsin pcsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pcsin pcsin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review Approved-Suppression labels Jan 27, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 27, 2025
@vikasagrawal-ms vikasagrawal-ms merged commit 7e8bb49 into Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2025-01-01-preview Jan 27, 2025
24 checks passed
ZhidaLiu added a commit to ZhidaLiu/azure-rest-api-specs that referenced this pull request Jan 27, 2025
* Distillation ARM changes

* Fix CSPell check

* Fixed Prettier Failures

* Fixed Model Validation

* Updated PromptSetting description

* Added Only Distillation Changes

* Added definitions

* removed unwanted changes

* Ran Prettier

* Updated swagger based on Vienna review

* Updated Examples

* Updated Description for Prompt Setting

* Reorganized as per review comments

* Updated examples

* Ran Prettier

* Handled review comments

* Added Suppression.yaml file

* Updated syntax

* Fixed syntax

* Added Suppressions in readme

---------

Co-Authored-By: Qiaoqiao Zhang <[email protected]>
ZhidaLiu pushed a commit that referenced this pull request Feb 10, 2025
* Distillation ARM changes

* Fix CSPell check

* Fixed Prettier Failures

* Fixed Model Validation

* Updated PromptSetting description

* Added Only Distillation Changes

* Added definitions

* removed unwanted changes

* Ran Prettier

* Updated swagger based on Vienna review

* Updated Examples

* Updated Description for Prompt Setting

* Reorganized as per review comments

* Updated examples

* Ran Prettier

* Handled review comments

* Added Suppression.yaml file

* Updated syntax

* Fixed syntax

* Added Suppressions in readme

---------

Co-authored-by: Qiaoqiao Zhang <[email protected]>
ragovada added a commit that referenced this pull request Feb 14, 2025
…ices 2025 01 01 preview (#32541)

* Copy files from preview/2024-10-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-01-01-preview

Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview.

* Added tag for 2025-01-01-preview in readme file

* Making updates to ActualCapacityInfo for Inference Group Status (#32002)

* Add ActualCapacityInfo contract changes to 2025 preview

* Making updates to ActualCapacityInfo for Group Status

* Add quota apis to MFE 20250101-preview (#31885)

* Add quota apis

* add location in swagger

* add list available quota

* add AvailableQuotaArmPaginatedResult

* add location param

* location param in examples

* replace with location parameters

* Removes azure-resource-manager-schemas from SDK automation. It can be re-added without reverting this commit. (#30893) (#31918)

This change produces an extra warning but no obvious new errors.

---------

Co-authored-by: Daniel Jurek <[email protected]>

* Prettier Gate fixes for Jan 25 preview (#31864)

Co-authored-by: ZhidaLiu <[email protected]>

* [MFE][2025-01-01-preview] Add deferred safety to serverless endpoints (#32030)

* Update mfe.json to add new content safety level property

* prettier

* more prettier

* Update createOrUpdate.json with contentsafetylevel

* Update get.json

* Update list.json

* Update update.json

* Update EnvironmentVersion with vulnerabilities object (#32075)

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Add parent job name (#32106)

* add parent job name

add parent job name

* prettier

prettier

* prettier

prettier

* Correct tag format (#32141)

* [MFE] Add AAD Auth Modes to Serverless Endpoint (#32100)

* add aad auth mode and cherrypick

* prettier

* remove getStatus change

* reset mfe, add back aad auth

* revert getStatus

* prettier cmd

* update mfe

* prettier

* cherrypick commit 1fc2fa1

* add newline back

* add newline back

* Lint diff fixes for Jan 25 preview (#31939)

* Lint diff fixes for Jan 25 preview

* Update tag

* Keep tag format consistent with other versions

* resolve merge conflicts

---------

Co-authored-by: ZhidaLiu <[email protected]>

* Release distillation changes (#32186)

* Distillation ARM changes

* Fix CSPell check

* Fixed Prettier Failures

* Fixed Model Validation

* Updated PromptSetting description

* Added Only Distillation Changes

* Added definitions

* removed unwanted changes

* Ran Prettier

* Updated swagger based on Vienna review

* Updated Examples

* Updated Description for Prompt Setting

* Reorganized as per review comments

* Updated examples

* Ran Prettier

* Handled review comments

* Added Suppression.yaml file

* Updated syntax

* Fixed syntax

* Added Suppressions in readme

---------

Co-authored-by: Qiaoqiao Zhang <[email protected]>

* Fix typo in vuln contract (#32280)

* Add the property irewallPublicIpAddress in ManagedNetworkSettings (#32123)

* Fix issue caused by rebase

* updated mfe.json (#32543)

* add more suppression for lint diff error that we can't fix (#32603)

---------

Co-authored-by: ragovada <[email protected]>
Co-authored-by: ritujhams <[email protected]>
Co-authored-by: jingyizhu99 <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>
Co-authored-by: ragovada <[email protected]>
Co-authored-by: liangjason87 <[email protected]>
Co-authored-by: vizhur <[email protected]>
Co-authored-by: marici7274 <[email protected]>
Co-authored-by: Karishma Daga <[email protected]>
Co-authored-by: vikasagrawal-ms <[email protected]>
Co-authored-by: Qiaoqiao Zhang <[email protected]>
Co-authored-by: haoranqian <[email protected]>
Co-authored-by: sarajag <[email protected]>
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
…ices 2025 01 01 preview (Azure#32541)

* Copy files from preview/2024-10-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-01-01-preview

Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview.

* Added tag for 2025-01-01-preview in readme file

* Making updates to ActualCapacityInfo for Inference Group Status (Azure#32002)

* Add ActualCapacityInfo contract changes to 2025 preview

* Making updates to ActualCapacityInfo for Group Status

* Add quota apis to MFE 20250101-preview (Azure#31885)

* Add quota apis

* add location in swagger

* add list available quota

* add AvailableQuotaArmPaginatedResult

* add location param

* location param in examples

* replace with location parameters

* Removes azure-resource-manager-schemas from SDK automation. It can be re-added without reverting this commit. (Azure#30893) (Azure#31918)

This change produces an extra warning but no obvious new errors.

---------

Co-authored-by: Daniel Jurek <[email protected]>

* Prettier Gate fixes for Jan 25 preview (Azure#31864)

Co-authored-by: ZhidaLiu <[email protected]>

* [MFE][2025-01-01-preview] Add deferred safety to serverless endpoints (Azure#32030)

* Update mfe.json to add new content safety level property

* prettier

* more prettier

* Update createOrUpdate.json with contentsafetylevel

* Update get.json

* Update list.json

* Update update.json

* Update EnvironmentVersion with vulnerabilities object (Azure#32075)

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Add parent job name (Azure#32106)

* add parent job name

add parent job name

* prettier

prettier

* prettier

prettier

* Correct tag format (Azure#32141)

* [MFE] Add AAD Auth Modes to Serverless Endpoint (Azure#32100)

* add aad auth mode and cherrypick

* prettier

* remove getStatus change

* reset mfe, add back aad auth

* revert getStatus

* prettier cmd

* update mfe

* prettier

* cherrypick commit 1fc2fa1

* add newline back

* add newline back

* Lint diff fixes for Jan 25 preview (Azure#31939)

* Lint diff fixes for Jan 25 preview

* Update tag

* Keep tag format consistent with other versions

* resolve merge conflicts

---------

Co-authored-by: ZhidaLiu <[email protected]>

* Release distillation changes (Azure#32186)

* Distillation ARM changes

* Fix CSPell check

* Fixed Prettier Failures

* Fixed Model Validation

* Updated PromptSetting description

* Added Only Distillation Changes

* Added definitions

* removed unwanted changes

* Ran Prettier

* Updated swagger based on Vienna review

* Updated Examples

* Updated Description for Prompt Setting

* Reorganized as per review comments

* Updated examples

* Ran Prettier

* Handled review comments

* Added Suppression.yaml file

* Updated syntax

* Fixed syntax

* Added Suppressions in readme

---------

Co-authored-by: Qiaoqiao Zhang <[email protected]>

* Fix typo in vuln contract (Azure#32280)

* Add the property irewallPublicIpAddress in ManagedNetworkSettings (Azure#32123)

* Fix issue caused by rebase

* updated mfe.json (Azure#32543)

* add more suppression for lint diff error that we can't fix (Azure#32603)

---------

Co-authored-by: ragovada <[email protected]>
Co-authored-by: ritujhams <[email protected]>
Co-authored-by: jingyizhu99 <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>
Co-authored-by: ragovada <[email protected]>
Co-authored-by: liangjason87 <[email protected]>
Co-authored-by: vizhur <[email protected]>
Co-authored-by: marici7274 <[email protected]>
Co-authored-by: Karishma Daga <[email protected]>
Co-authored-by: vikasagrawal-ms <[email protected]>
Co-authored-by: Qiaoqiao Zhang <[email protected]>
Co-authored-by: haoranqian <[email protected]>
Co-authored-by: sarajag <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review AzCoreIDC resource-manager SuppressionReviewRequired

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants