-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Release distillation changes #32186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release distillation changes #32186
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
|
There are 3 gate failures |
…ngServices-2025-01-01-preview' into release-Distillation-changes
|
The JS failure should have been fixed. |
...vices/resource-manager/Microsoft.MachineLearningServices/preview/2025-01-01-preview/mfe.json
Show resolved
Hide resolved
...vices/resource-manager/Microsoft.MachineLearningServices/preview/2025-01-01-preview/mfe.json
Show resolved
Hide resolved
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
…ngServices-2025-01-01-preview' into release-Distillation-changes
| "type": "object", | ||
| "properties": { | ||
| "enableChainOfDensity": { | ||
| "type": "boolean" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pcsin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
7e8bb49
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2025-01-01-preview
* Distillation ARM changes * Fix CSPell check * Fixed Prettier Failures * Fixed Model Validation * Updated PromptSetting description * Added Only Distillation Changes * Added definitions * removed unwanted changes * Ran Prettier * Updated swagger based on Vienna review * Updated Examples * Updated Description for Prompt Setting * Reorganized as per review comments * Updated examples * Ran Prettier * Handled review comments * Added Suppression.yaml file * Updated syntax * Fixed syntax * Added Suppressions in readme --------- Co-Authored-By: Qiaoqiao Zhang <[email protected]>
* Distillation ARM changes * Fix CSPell check * Fixed Prettier Failures * Fixed Model Validation * Updated PromptSetting description * Added Only Distillation Changes * Added definitions * removed unwanted changes * Ran Prettier * Updated swagger based on Vienna review * Updated Examples * Updated Description for Prompt Setting * Reorganized as per review comments * Updated examples * Ran Prettier * Handled review comments * Added Suppression.yaml file * Updated syntax * Fixed syntax * Added Suppressions in readme --------- Co-authored-by: Qiaoqiao Zhang <[email protected]>
…ices 2025 01 01 preview (#32541) * Copy files from preview/2024-10-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2025-01-01-preview Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview. * Added tag for 2025-01-01-preview in readme file * Making updates to ActualCapacityInfo for Inference Group Status (#32002) * Add ActualCapacityInfo contract changes to 2025 preview * Making updates to ActualCapacityInfo for Group Status * Add quota apis to MFE 20250101-preview (#31885) * Add quota apis * add location in swagger * add list available quota * add AvailableQuotaArmPaginatedResult * add location param * location param in examples * replace with location parameters * Removes azure-resource-manager-schemas from SDK automation. It can be re-added without reverting this commit. (#30893) (#31918) This change produces an extra warning but no obvious new errors. --------- Co-authored-by: Daniel Jurek <[email protected]> * Prettier Gate fixes for Jan 25 preview (#31864) Co-authored-by: ZhidaLiu <[email protected]> * [MFE][2025-01-01-preview] Add deferred safety to serverless endpoints (#32030) * Update mfe.json to add new content safety level property * prettier * more prettier * Update createOrUpdate.json with contentsafetylevel * Update get.json * Update list.json * Update update.json * Update EnvironmentVersion with vulnerabilities object (#32075) * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Add parent job name (#32106) * add parent job name add parent job name * prettier prettier * prettier prettier * Correct tag format (#32141) * [MFE] Add AAD Auth Modes to Serverless Endpoint (#32100) * add aad auth mode and cherrypick * prettier * remove getStatus change * reset mfe, add back aad auth * revert getStatus * prettier cmd * update mfe * prettier * cherrypick commit 1fc2fa1 * add newline back * add newline back * Lint diff fixes for Jan 25 preview (#31939) * Lint diff fixes for Jan 25 preview * Update tag * Keep tag format consistent with other versions * resolve merge conflicts --------- Co-authored-by: ZhidaLiu <[email protected]> * Release distillation changes (#32186) * Distillation ARM changes * Fix CSPell check * Fixed Prettier Failures * Fixed Model Validation * Updated PromptSetting description * Added Only Distillation Changes * Added definitions * removed unwanted changes * Ran Prettier * Updated swagger based on Vienna review * Updated Examples * Updated Description for Prompt Setting * Reorganized as per review comments * Updated examples * Ran Prettier * Handled review comments * Added Suppression.yaml file * Updated syntax * Fixed syntax * Added Suppressions in readme --------- Co-authored-by: Qiaoqiao Zhang <[email protected]> * Fix typo in vuln contract (#32280) * Add the property irewallPublicIpAddress in ManagedNetworkSettings (#32123) * Fix issue caused by rebase * updated mfe.json (#32543) * add more suppression for lint diff error that we can't fix (#32603) --------- Co-authored-by: ragovada <[email protected]> Co-authored-by: ritujhams <[email protected]> Co-authored-by: jingyizhu99 <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: ragovada <[email protected]> Co-authored-by: liangjason87 <[email protected]> Co-authored-by: vizhur <[email protected]> Co-authored-by: marici7274 <[email protected]> Co-authored-by: Karishma Daga <[email protected]> Co-authored-by: vikasagrawal-ms <[email protected]> Co-authored-by: Qiaoqiao Zhang <[email protected]> Co-authored-by: haoranqian <[email protected]> Co-authored-by: sarajag <[email protected]>
…ices 2025 01 01 preview (Azure#32541) * Copy files from preview/2024-10-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2025-01-01-preview Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview. * Added tag for 2025-01-01-preview in readme file * Making updates to ActualCapacityInfo for Inference Group Status (Azure#32002) * Add ActualCapacityInfo contract changes to 2025 preview * Making updates to ActualCapacityInfo for Group Status * Add quota apis to MFE 20250101-preview (Azure#31885) * Add quota apis * add location in swagger * add list available quota * add AvailableQuotaArmPaginatedResult * add location param * location param in examples * replace with location parameters * Removes azure-resource-manager-schemas from SDK automation. It can be re-added without reverting this commit. (Azure#30893) (Azure#31918) This change produces an extra warning but no obvious new errors. --------- Co-authored-by: Daniel Jurek <[email protected]> * Prettier Gate fixes for Jan 25 preview (Azure#31864) Co-authored-by: ZhidaLiu <[email protected]> * [MFE][2025-01-01-preview] Add deferred safety to serverless endpoints (Azure#32030) * Update mfe.json to add new content safety level property * prettier * more prettier * Update createOrUpdate.json with contentsafetylevel * Update get.json * Update list.json * Update update.json * Update EnvironmentVersion with vulnerabilities object (Azure#32075) * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Add parent job name (Azure#32106) * add parent job name add parent job name * prettier prettier * prettier prettier * Correct tag format (Azure#32141) * [MFE] Add AAD Auth Modes to Serverless Endpoint (Azure#32100) * add aad auth mode and cherrypick * prettier * remove getStatus change * reset mfe, add back aad auth * revert getStatus * prettier cmd * update mfe * prettier * cherrypick commit 1fc2fa1 * add newline back * add newline back * Lint diff fixes for Jan 25 preview (Azure#31939) * Lint diff fixes for Jan 25 preview * Update tag * Keep tag format consistent with other versions * resolve merge conflicts --------- Co-authored-by: ZhidaLiu <[email protected]> * Release distillation changes (Azure#32186) * Distillation ARM changes * Fix CSPell check * Fixed Prettier Failures * Fixed Model Validation * Updated PromptSetting description * Added Only Distillation Changes * Added definitions * removed unwanted changes * Ran Prettier * Updated swagger based on Vienna review * Updated Examples * Updated Description for Prompt Setting * Reorganized as per review comments * Updated examples * Ran Prettier * Handled review comments * Added Suppression.yaml file * Updated syntax * Fixed syntax * Added Suppressions in readme --------- Co-authored-by: Qiaoqiao Zhang <[email protected]> * Fix typo in vuln contract (Azure#32280) * Add the property irewallPublicIpAddress in ManagedNetworkSettings (Azure#32123) * Fix issue caused by rebase * updated mfe.json (Azure#32543) * add more suppression for lint diff error that we can't fix (Azure#32603) --------- Co-authored-by: ragovada <[email protected]> Co-authored-by: ritujhams <[email protected]> Co-authored-by: jingyizhu99 <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: ragovada <[email protected]> Co-authored-by: liangjason87 <[email protected]> Co-authored-by: vizhur <[email protected]> Co-authored-by: marici7274 <[email protected]> Co-authored-by: Karishma Daga <[email protected]> Co-authored-by: vikasagrawal-ms <[email protected]> Co-authored-by: Qiaoqiao Zhang <[email protected]> Co-authored-by: haoranqian <[email protected]> Co-authored-by: sarajag <[email protected]>
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
The Swagger LintDiff fails with the AvoidAdditionalProperties rule. However, this is necessary to allow users to specify custom inference parameters and fine-tuning hyperparameters for any model. Enforcing typecasting would require modifying contracts for each new addition by model providers. A similar approach has been previously permitted for the FinetuningJob.
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
DistillationJob
This PR introduces a new job type called DistillationJob. In this job, a teacher model is used to prepare a dataset through inference, and a student model is fine-tuned on the prepared dataset. The DistillationJob is flexible and does not enforce fixed models, allowing users to select any model available in the Model Catalogue. These models, provided by third-party model providers, can include custom hyperparameters for fine-tuning and inference parameters as needed.
Suppressing failures
The Swagger LintDiff fails with the AvoidAdditionalProperties rule. However, this is necessary to allow users to specify custom inference parameters and fine-tuning hyperparameters for any model. Enforcing typecasting would require modifying contracts for each new addition by model providers. A similar approach has been previously permitted for the FinetuningJob.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.