[MFE] Add AAD Auth Modes to Serverless Endpoint #32100

karishmadaga · 2025-01-10T18:58:38Z

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

openapi-pipeline-app · 2025-01-10T18:58:43Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2025-01-10T18:58:43Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/machinelearning/armmachinelearning	There is no API change compared with the previous version
Java	azure-resourcemanager-machinelearning	https://apiview.dev/Assemblies/Review/e1c428cb12c840a2b15ad2ba61d138e7?revisionId=6d45f92d717b4b0b8fe20f4ea0b61bd3
.Net	Azure.ResourceManager.MachineLearning	https://apiview.dev/Assemblies/Review/b3a1424a42c346a8906822f457909b53?revisionId=2d4ee2551c794865879826060c98653c

...vices/resource-manager/Microsoft.MachineLearningServices/preview/2025-01-01-preview/mfe.json

...LearningServices/preview/2025-01-01-preview/examples/Workspace/InferenceGroup/getStatus.json

ms-bogdan-rotaru · 2025-01-13T12:24:43Z

Is this ready for ARM review?

ms-bogdan-rotaru · 2025-01-13T12:24:53Z

/azp run

openapi-pipeline-app · 2025-01-13T12:24:56Z

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

azure-pipelines · 2025-01-13T12:24:59Z

Pull request contains merge conflicts.

karishmadaga · 2025-01-13T15:16:22Z

Is this ready for ARM review?

Will be ready for review by this afternoon!

…ngServices-2025-01-01-preview' into karishma/aad-auth-serverless-endpoint

…b.com/karishmadaga/azure-rest-api-specs into karishma/aad-auth-serverless-endpoint

…ngServices-2025-01-01-preview' into karishma/aad-auth-serverless-endpoint

ZhidaLiu · 2025-01-14T04:42:27Z

/azp run

azure-pipelines · 2025-01-14T04:42:40Z

Azure Pipelines successfully started running 2 pipeline(s).

karishmadaga · 2025-01-14T16:38:54Z

Is this ready for ARM review?

Hey @ms-bogdan-rotaru, this is ready for review

ZhidaLiu · 2025-01-14T17:20:29Z

@ms-bogdan-rotaru any idea why some of the pipeline is not running? I'm request through /azp run several times

…ngServices-2025-01-01-preview' into karishma/aad-auth-serverless-endpoint

…b.com/karishmadaga/azure-rest-api-specs into karishma/aad-auth-serverless-endpoint Need to bring upstream changes into branch.

…b.com/karishmadaga/azure-rest-api-specs into karishma/aad-auth-serverless-endpoint

karishmadaga · 2025-01-15T22:43:25Z

/azp run

azure-pipelines · 2025-01-15T22:43:31Z

Commenter does not have sufficient privileges for PR 32100 in repo Azure/azure-rest-api-specs

ragovada · 2025-01-15T22:52:35Z

/azp run

azure-pipelines · 2025-01-15T22:52:48Z

Azure Pipelines successfully started running 2 pipeline(s).

…ngServices-2025-01-01-preview' into karishma/aad-auth-serverless-endpoint

* add aad auth mode and cherrypick * prettier * remove getStatus change * reset mfe, add back aad auth * revert getStatus * prettier cmd * update mfe * prettier * cherrypick commit 1fc2fa1 * add newline back * add newline back

…ices 2025 01 01 preview (#32541) * Copy files from preview/2024-10-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2025-01-01-preview Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview. * Added tag for 2025-01-01-preview in readme file * Making updates to ActualCapacityInfo for Inference Group Status (#32002) * Add ActualCapacityInfo contract changes to 2025 preview * Making updates to ActualCapacityInfo for Group Status * Add quota apis to MFE 20250101-preview (#31885) * Add quota apis * add location in swagger * add list available quota * add AvailableQuotaArmPaginatedResult * add location param * location param in examples * replace with location parameters * Removes azure-resource-manager-schemas from SDK automation. It can be re-added without reverting this commit. (#30893) (#31918) This change produces an extra warning but no obvious new errors. --------- Co-authored-by: Daniel Jurek <[email protected]> * Prettier Gate fixes for Jan 25 preview (#31864) Co-authored-by: ZhidaLiu <[email protected]> * [MFE][2025-01-01-preview] Add deferred safety to serverless endpoints (#32030) * Update mfe.json to add new content safety level property * prettier * more prettier * Update createOrUpdate.json with contentsafetylevel * Update get.json * Update list.json * Update update.json * Update EnvironmentVersion with vulnerabilities object (#32075) * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Add parent job name (#32106) * add parent job name add parent job name * prettier prettier * prettier prettier * Correct tag format (#32141) * [MFE] Add AAD Auth Modes to Serverless Endpoint (#32100) * add aad auth mode and cherrypick * prettier * remove getStatus change * reset mfe, add back aad auth * revert getStatus * prettier cmd * update mfe * prettier * cherrypick commit 1fc2fa1 * add newline back * add newline back * Lint diff fixes for Jan 25 preview (#31939) * Lint diff fixes for Jan 25 preview * Update tag * Keep tag format consistent with other versions * resolve merge conflicts --------- Co-authored-by: ZhidaLiu <[email protected]> * Release distillation changes (#32186) * Distillation ARM changes * Fix CSPell check * Fixed Prettier Failures * Fixed Model Validation * Updated PromptSetting description * Added Only Distillation Changes * Added definitions * removed unwanted changes * Ran Prettier * Updated swagger based on Vienna review * Updated Examples * Updated Description for Prompt Setting * Reorganized as per review comments * Updated examples * Ran Prettier * Handled review comments * Added Suppression.yaml file * Updated syntax * Fixed syntax * Added Suppressions in readme --------- Co-authored-by: Qiaoqiao Zhang <[email protected]> * Fix typo in vuln contract (#32280) * Add the property irewallPublicIpAddress in ManagedNetworkSettings (#32123) * Fix issue caused by rebase * updated mfe.json (#32543) * add more suppression for lint diff error that we can't fix (#32603) --------- Co-authored-by: ragovada <[email protected]> Co-authored-by: ritujhams <[email protected]> Co-authored-by: jingyizhu99 <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: ragovada <[email protected]> Co-authored-by: liangjason87 <[email protected]> Co-authored-by: vizhur <[email protected]> Co-authored-by: marici7274 <[email protected]> Co-authored-by: Karishma Daga <[email protected]> Co-authored-by: vikasagrawal-ms <[email protected]> Co-authored-by: Qiaoqiao Zhang <[email protected]> Co-authored-by: haoranqian <[email protected]> Co-authored-by: sarajag <[email protected]>

…ices 2025 01 01 preview (Azure#32541) * Copy files from preview/2024-10-01-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2025-01-01-preview Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview. * Added tag for 2025-01-01-preview in readme file * Making updates to ActualCapacityInfo for Inference Group Status (Azure#32002) * Add ActualCapacityInfo contract changes to 2025 preview * Making updates to ActualCapacityInfo for Group Status * Add quota apis to MFE 20250101-preview (Azure#31885) * Add quota apis * add location in swagger * add list available quota * add AvailableQuotaArmPaginatedResult * add location param * location param in examples * replace with location parameters * Removes azure-resource-manager-schemas from SDK automation. It can be re-added without reverting this commit. (Azure#30893) (Azure#31918) This change produces an extra warning but no obvious new errors. --------- Co-authored-by: Daniel Jurek <[email protected]> * Prettier Gate fixes for Jan 25 preview (Azure#31864) Co-authored-by: ZhidaLiu <[email protected]> * [MFE][2025-01-01-preview] Add deferred safety to serverless endpoints (Azure#32030) * Update mfe.json to add new content safety level property * prettier * more prettier * Update createOrUpdate.json with contentsafetylevel * Update get.json * Update list.json * Update update.json * Update EnvironmentVersion with vulnerabilities object (Azure#32075) * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * Add parent job name (Azure#32106) * add parent job name add parent job name * prettier prettier * prettier prettier * Correct tag format (Azure#32141) * [MFE] Add AAD Auth Modes to Serverless Endpoint (Azure#32100) * add aad auth mode and cherrypick * prettier * remove getStatus change * reset mfe, add back aad auth * revert getStatus * prettier cmd * update mfe * prettier * cherrypick commit 1fc2fa1 * add newline back * add newline back * Lint diff fixes for Jan 25 preview (Azure#31939) * Lint diff fixes for Jan 25 preview * Update tag * Keep tag format consistent with other versions * resolve merge conflicts --------- Co-authored-by: ZhidaLiu <[email protected]> * Release distillation changes (Azure#32186) * Distillation ARM changes * Fix CSPell check * Fixed Prettier Failures * Fixed Model Validation * Updated PromptSetting description * Added Only Distillation Changes * Added definitions * removed unwanted changes * Ran Prettier * Updated swagger based on Vienna review * Updated Examples * Updated Description for Prompt Setting * Reorganized as per review comments * Updated examples * Ran Prettier * Handled review comments * Added Suppression.yaml file * Updated syntax * Fixed syntax * Added Suppressions in readme --------- Co-authored-by: Qiaoqiao Zhang <[email protected]> * Fix typo in vuln contract (Azure#32280) * Add the property irewallPublicIpAddress in ManagedNetworkSettings (Azure#32123) * Fix issue caused by rebase * updated mfe.json (Azure#32543) * add more suppression for lint diff error that we can't fix (Azure#32603) --------- Co-authored-by: ragovada <[email protected]> Co-authored-by: ritujhams <[email protected]> Co-authored-by: jingyizhu99 <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: ragovada <[email protected]> Co-authored-by: liangjason87 <[email protected]> Co-authored-by: vizhur <[email protected]> Co-authored-by: marici7274 <[email protected]> Co-authored-by: Karishma Daga <[email protected]> Co-authored-by: vikasagrawal-ms <[email protected]> Co-authored-by: Qiaoqiao Zhang <[email protected]> Co-authored-by: haoranqian <[email protected]> Co-authored-by: sarajag <[email protected]>

add aad auth mode and cherrypick

4a8a59c

karishmadaga requested review from benbp, mikeharder and weshaggard as code owners January 10, 2025 18:58

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 10, 2025

karishmadaga added 2 commits January 10, 2025 14:37

prettier

913c11c

remove getStatus change

ec5585a

ZhidaLiu reviewed Jan 10, 2025

View reviewed changes

...vices/resource-manager/Microsoft.MachineLearningServices/preview/2025-01-01-preview/mfe.json Show resolved Hide resolved

ZhidaLiu reviewed Jan 10, 2025

View reviewed changes

...LearningServices/preview/2025-01-01-preview/examples/Workspace/InferenceGroup/getStatus.json Outdated Show resolved Hide resolved

ms-bogdan-rotaru added the ARMChangesRequested label Jan 13, 2025

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 13, 2025

Merge branch 'release-machinelearningservices-Microsoft.MachineLearni…

2844966

…ngServices-2025-01-01-preview' into karishma/aad-auth-serverless-endpoint

azure-sdk mentioned this pull request Jan 13, 2025

[AutoPR azure-resourcemanager-machinelearning] [MFE] Add AAD Auth Modes to Serverless Endpoint azure-sdk/azure-sdk-for-java#13666

Closed

karishmadaga added 6 commits January 13, 2025 22:34

reset mfe, add back aad auth

4d833a2

Merge branch 'karishma/aad-auth-serverless-endpoint' of https://githu…

c87699b

…b.com/karishmadaga/azure-rest-api-specs into karishma/aad-auth-serverless-endpoint

Merge branch 'release-machinelearningservices-Microsoft.MachineLearni…

8f9380b

…ngServices-2025-01-01-preview' into karishma/aad-auth-serverless-endpoint

revert getStatus

4bb197c

prettier cmd

0956a73

update mfe

d4d35c1

cherrypick commit 1fc2fa1

7fed8aa

ZhidaLiu removed the ARMChangesRequested label Jan 14, 2025

openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 14, 2025

ZhidaLiu approved these changes Jan 14, 2025

View reviewed changes

karishmadaga added 5 commits January 15, 2025 16:44

Merge branch 'release-machinelearningservices-Microsoft.MachineLearni…

eb5696d

…ngServices-2025-01-01-preview' into karishma/aad-auth-serverless-endpoint

add newline back

da66d3d

add newline back

ff65775

Merge branch 'karishma/aad-auth-serverless-endpoint' of https://githu…

2298d8e

…b.com/karishmadaga/azure-rest-api-specs into karishma/aad-auth-serverless-endpoint Need to bring upstream changes into branch.

Merge branch 'karishma/aad-auth-serverless-endpoint' of https://githu…

bd723c3

…b.com/karishmadaga/azure-rest-api-specs into karishma/aad-auth-serverless-endpoint

ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 16, 2025

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 16, 2025

karishmadaga added 2 commits January 16, 2025 12:07

Merge branch 'release-machinelearningservices-Microsoft.MachineLearni…

7acd361

…ngServices-2025-01-01-preview' into karishma/aad-auth-serverless-endpoint

Merge branch 'release-machinelearningservices-Microsoft.MachineLearni…

6919143

…ngServices-2025-01-01-preview' into karishma/aad-auth-serverless-endpoint

ragovada merged commit 4cc7d06 into Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2025-01-01-preview Jan 17, 2025
24 of 25 checks passed

ragovada mentioned this pull request Feb 14, 2025

Merge release machinelearningservices microsoft.machine learning services 2025 01 01 preview #32541

Merged

8 tasks

[MFE] Add AAD Auth Modes to Serverless Endpoint #32100

[MFE] Add AAD Auth Modes to Serverless Endpoint #32100

Uh oh!

Conversation

karishmadaga commented Jan 10, 2025

Choose a PR Template

Uh oh!

openapi-pipeline-app bot commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

Uh oh!

Uh oh!

ms-bogdan-rotaru commented Jan 13, 2025

Uh oh!

ms-bogdan-rotaru commented Jan 13, 2025

Uh oh!

openapi-pipeline-app bot commented Jan 13, 2025

Uh oh!

azure-pipelines bot commented Jan 13, 2025

Uh oh!

karishmadaga commented Jan 13, 2025

Uh oh!

ZhidaLiu commented Jan 14, 2025

Uh oh!

azure-pipelines bot commented Jan 14, 2025

Uh oh!

karishmadaga commented Jan 14, 2025

Uh oh!

ZhidaLiu commented Jan 14, 2025

Uh oh!

karishmadaga commented Jan 15, 2025

Uh oh!

azure-pipelines bot commented Jan 15, 2025

Uh oh!

ragovada commented Jan 15, 2025

Uh oh!

azure-pipelines bot commented Jan 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openapi-pipeline-app bot commented Jan 10, 2025 •

edited

Loading

openapi-pipeline-app bot commented Jan 10, 2025 •

edited

Loading