Implementation of Number Lookup feature for public preview in communication-phonenumbers #35674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericasp16
requested review from
RoyHerrod,
danielav7,
miguhern and
whisper6284
as code owners
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
2 tasks
ericasp16
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jul 20, 2023
### Packages impacted by this PR communication-phone-numbers ### Issues associated with this PR Azure/azure-sdk#6321 ### Describe the problem that is addressed by this PR Adding number lookup endpoint to the SDK ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ Yes ### Provide a list of related PRs _(if any)_ Azure/azure-sdk-for-java#35674 Azure/azure-sdk-for-python#31053 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [X] Added impacted package name to the issue description - [n/a] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [X] Added a changelog (if necessary)
…se, update test recordings
guoqing2023
approved these changes
Jul 26, 2023
ericasp16
added a commit
that referenced
this pull request
Jan 29, 2024
GA implementation of the number lookup feature. This commit should cover the vast majority of the work needed, and is updated to incorporate feedback from the stewardship board. These changes are going into a branch to wait until we're ready to do our final bug bashing and eventually merging and shipping the feature. ---------- * Implementation of Number Lookup feature for public preview in communication-phonenumbers (#35674) * implementation of number lookup in java SDK * fix readme to remove debug logging * fix autorest generation swagger mismatch issue * update autorest generation and yaml directives * update service version * fix public/private type generation, update changelog * fix checkstyle issues * update test recordings * update test base to redact phonenumbers in operatorInformation response, update test recordings * update changelog * update date format for changelog * Increment package versions for communication releases (#36670) * fix imports in test file * update auto-generated files * implement ga updates * removing edits to version_client.txt * fix build errors * attempt to fix versioning issue * update based on SDK review --------- Co-authored-by: Azure SDK Bot <[email protected]>
ericasp16
added a commit
that referenced
this pull request
Mar 14, 2024
…38885) * Number lookup ga (#37719) GA implementation of the number lookup feature. This commit should cover the vast majority of the work needed, and is updated to incorporate feedback from the stewardship board. These changes are going into a branch to wait until we're ready to do our final bug bashing and eventually merging and shipping the feature. ---------- * Implementation of Number Lookup feature for public preview in communication-phonenumbers (#35674) * implementation of number lookup in java SDK * fix readme to remove debug logging * fix autorest generation swagger mismatch issue * update autorest generation and yaml directives * update service version * fix public/private type generation, update changelog * fix checkstyle issues * update test recordings * update test base to redact phonenumbers in operatorInformation response, update test recordings * update changelog * update date format for changelog * Increment package versions for communication releases (#36670) * fix imports in test file * update auto-generated files * implement ga updates * removing edits to version_client.txt * fix build errors * attempt to fix versioning issue * update based on SDK review --------- Co-authored-by: Azure SDK Bot <[email protected]> * update generated code * update test recordings * update package to beta version * update service version * fix build issues * fix linting issue * update to address comments, restore unintentionally modified tests * restore unintentionally modified tests * restore unintentionally modified tests * fix version_client * fix import statements * update test files * update test files * update test files * update searchOperatorInformation tests to redact phone number * update with latest tests * update tests and recordings * update test files to redact phoneNumbers in request body for searchOperatorInformation tests * remove setters on return type fields * update based on API view comments * fix build errors * fix sanitizers, update test recordings * update based on PR comments * fix errors --------- Co-authored-by: Azure SDK Bot <[email protected]>
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-js
that referenced
this pull request
Apr 11, 2024
communication-phone-numbers Azure/azure-sdk#6321 Adding number lookup endpoint to the SDK there are more than one possible design, why was the one in this PR chosen? Yes Azure/azure-sdk-for-java#35674 Azure/azure-sdk-for-python#31053 request PRs)_ - [X] Added impacted package name to the issue description - [n/a] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [X] Added a changelog (if necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This review covers adding a new endpoint to the communication-phonenumbers package. This new endpoint enables the number lookup feature which is currently in private preview and will be going to public preview in August.
Number Lookup enables developers to check the operator information for a phone number which will allow them to make an informed decision before contacting a potential recipient, including checking whether the recipient number is likely to be able to receive SMS messages.
The latest PR describing the API's swagger updates can be found here: Azure/azure-rest-api-specs#24223
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines