Skip to content

Implementation of Number Lookup feature for public preview in communication-phonenumbers #35674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericasp16 merged 11 commits into from
Jul 26, 2023
Merged

Implementation of Number Lookup feature for public preview in communication-phonenumbers #35674

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a1c133b
implementation of number lookup in java SDK
ericasp16 Jun 29, 2023
0df893a
fix readme to remove debug logging
ericasp16 Jun 29, 2023
b298f7e
fix autorest generation swagger mismatch issue
ericasp16 Jul 1, 2023
21b7b07
update autorest generation and yaml directives
ericasp16 Jul 11, 2023
b417dae
update service version
ericasp16 Jul 11, 2023
3ba05c8
fix public/private type generation, update changelog
ericasp16 Jul 21, 2023
0ad0f5a
Merge branch 'main' into ericasp/add-number-lookup-to-communication-p…
ericasp16 Jul 21, 2023
9a21aac
fix checkstyle issues
ericasp16 Jul 21, 2023
40721b9
update test recordings
ericasp16 Jul 25, 2023
81bec08
update test base to redact phonenumbers in operatorInformation respon…
ericasp16 Jul 26, 2023
6c7d7e3
Merge branch 'main' into ericasp/add-number-lookup-to-communication-p…
ericasp16 Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix autorest generation swagger mismatch issue
  • Loading branch information
@ericasp16
ericasp16 committed Jul 1, 2023
commit b298f7ee804babb9ef73c37be92f2cb67ee91982
57 changes: 2 additions & 55 deletions ...rs/src/main/java/com/azure/communication/phonenumbers/models/PhoneNumberSearchResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@

package com.azure.communication.phonenumbers.models;

import com.azure.communication.phonenumbers.implementation.models.PhoneNumberSearchResultError;
import com.azure.core.annotation.Fluent;
import com.azure.core.annotation.Immutable;
import com.fasterxml.jackson.annotation.JsonProperty;
import java.time.OffsetDateTime;
import java.util.List;

/** The result of a phone number search operation. */
@Fluent
@Immutable
public final class PhoneNumberSearchResult {
/*
* The search id.
Expand Down Expand Up @@ -58,18 +57,6 @@ public final class PhoneNumberSearchResult {
@JsonProperty(value = "searchExpiresBy", required = true, access = JsonProperty.Access.WRITE_ONLY)
private OffsetDateTime searchExpiresBy;

/*
* The error code of the search.
*/
@JsonProperty(value = "errorCode")
private Integer errorCode;

/*
* Mapping Error Messages to Codes
*/
@JsonProperty(value = "error")
private PhoneNumberSearchResultError error;

/**
* Get the searchId property: The search id.
*
Expand Down Expand Up @@ -134,44 +121,4 @@ public PhoneNumberCost getCost() {
public OffsetDateTime getSearchExpiresBy() {
return this.searchExpiresBy;
}

/**
* Get the errorCode property: The error code of the search.
*
* @return the errorCode value.
*/
public Integer getErrorCode() {
return this.errorCode;
}

/**
* Set the errorCode property: The error code of the search.
*
* @param errorCode the errorCode value to set.
* @return the PhoneNumberSearchResult object itself.
*/
public PhoneNumberSearchResult setErrorCode(Integer errorCode) {
this.errorCode = errorCode;
return this;
}

/**
* Get the error property: Mapping Error Messages to Codes.
*
* @return the error value.
*/
public PhoneNumberSearchResultError getError() {
return this.error;
}

/**
* Set the error property: Mapping Error Messages to Codes.
*
* @param error the error value to set.
* @return the PhoneNumberSearchResult object itself.
*/
public PhoneNumberSearchResult setError(PhoneNumberSearchResultError error) {
this.error = error;
return this;
}
}
22 changes: 2 additions & 20 deletions sdk/communication/azure-communication-phonenumbers/swagger/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ autorest README.md --java --v4 --use=@autorest/[email protected]
### Code generation settings
``` yaml
tag: package-phonenumber-2023-05-01-preview
require: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/4d2e746ac1e094f87bfe0807b1d51b375a6c5517/specification/communication/data-plane/PhoneNumbers/readme.md
require: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/2d4881cf7101773b8c677a267b53d915b30a8c6c/specification/communication/data-plane/PhoneNumbers/readme.md
override-client-name: PhoneNumberAdminClient
custom-types: PurchasedPhoneNumber,BillingFrequency,PhoneNumberOperationStatus,PhoneNumberOperationStatusCodes,PhoneNumberOperationType,PhoneNumberAssignmentType,PhoneNumberCapabilities,PhoneNumberCapabilityType,PhoneNumberCost,PhoneNumberSearchResult,PhoneNumberType,PhoneNumberCapability,PhoneNumberAdministrativeDivision,PhoneNumberCountry,PhoneNumberLocality,PhoneNumberOffering,AreaCodeResult,AreaCodes,PhoneNumberAreaCode,OperatorDetails,OperatorInformation,OperatorInformationRequest,OperatorInformationResult,OperatorNumberType
custom-types-subpackage: models
Expand Down Expand Up @@ -190,22 +190,4 @@ directive:
transform: >
$["properties"]["localizedName"].readOnly = true;
$["properties"]["countryCode"].readOnly = true;
```

### Change a generic error to more specific name
``` yaml
directive:
from: swagger-document
where: $.definitions.PhoneNumberSearchResult.properties.error.x-ms-enum
transform: >
$["name"] = "PhoneNumberSearchResultError";
```

### Change a generic error to more specific name
``` yaml
directive:
from: swagger-document
where: $.parameters.Endpoint
debug: true
transform: >
$["format"] = "";
```