Skip to content

Implementation of Number Lookup feature for public preview in communication-phonenumbers #35674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericasp16 merged 11 commits into from
Jul 26, 2023
Merged

Implementation of Number Lookup feature for public preview in communication-phonenumbers #35674

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a1c133b
implementation of number lookup in java SDK
ericasp16 Jun 29, 2023
0df893a
fix readme to remove debug logging
ericasp16 Jun 29, 2023
b298f7e
fix autorest generation swagger mismatch issue
ericasp16 Jul 1, 2023
21b7b07
update autorest generation and yaml directives
ericasp16 Jul 11, 2023
b417dae
update service version
ericasp16 Jul 11, 2023
3ba05c8
fix public/private type generation, update changelog
ericasp16 Jul 21, 2023
0ad0f5a
Merge branch 'main' into ericasp/add-number-lookup-to-communication-p…
ericasp16 Jul 21, 2023
9a21aac
fix checkstyle issues
ericasp16 Jul 21, 2023
40721b9
update test recordings
ericasp16 Jul 25, 2023
81bec08
update test base to redact phonenumbers in operatorInformation respon…
ericasp16 Jul 26, 2023
6c7d7e3
Merge branch 'main' into ericasp/add-number-lookup-to-communication-p…
ericasp16 Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update service version
  • Loading branch information
@ericasp16
ericasp16 committed Jul 11, 2023
commit b417dae56eda7c80b908839e9371b117793ba90e
11 changes: 8 additions & 3 deletions ...umbers/src/main/java/com/azure/communication/phonenumbers/PhoneNumbersServiceVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,14 @@
*/
public enum PhoneNumbersServiceVersion implements ServiceVersion {
/**
* Service version {@code 2023-05-01-preview}
* Latest stable service version {@code 2021-03-07}
*/
NumberLookupPreview("2023-05-01-preview");
V2021_03_07("2021-03-07"),

/**
* Number Lookup preview version {@code 2023-05-01-preview}
*/
V2023_05_01_Preview("2023-05-01-preview");

private final String version;

Expand All @@ -37,6 +42,6 @@ public String getVersion() {
*/
public static PhoneNumbersServiceVersion getLatest() {

return NumberLookupPreview;
return V2023_05_01_Preview;
}
}
4 changes: 2 additions & 2 deletions ...ers/src/test/java/com/azure/communication/phonenumbers/PhoneNumbersClientBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public void buildClientWithConfiguration() {
public void buildClientWithServiceVersion() {
// Build client with required settings and mock configuration
PhoneNumbersClient phoneNumberClient = this.setupBuilderWithHttpClientWithCredential(this.clientBuilder)
.serviceVersion(PhoneNumbersServiceVersion.NumberLookupPreview)
.serviceVersion(PhoneNumbersServiceVersion.V2023_05_01_Preview)
.buildClient();

// Validate client created with expected settings
Expand Down Expand Up @@ -227,7 +227,7 @@ public void buildAsyncClientWithServiceVersion() {
// Build client with required settings and mock configuration
PhoneNumbersAsyncClient phoneNumberAsyncClient = this
.setupBuilderWithHttpClientWithCredential(this.clientBuilder)
.serviceVersion(PhoneNumbersServiceVersion.NumberLookupPreview)
.serviceVersion(PhoneNumbersServiceVersion.V2023_05_01_Preview)
.buildAsyncClient();

// Validate client created with expected settings
Expand Down