Skip to content

Conversation

@YalinLi0312
Copy link

For issue: #22661

@YalinLi0312 YalinLi0312 added KeyVault Client This issue points to a problem in the data-plane of the library. labels Mar 1, 2022
@YalinLi0312 YalinLi0312 requested a review from danieljurek March 1, 2022 13:50
Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge improvement, thank you! Again, might want to wait for @danieljurek's approval before merging.

Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 ❗

@YalinLi0312 YalinLi0312 merged commit f2354fd into Azure:main Mar 3, 2022
@YalinLi0312 YalinLi0312 deleted the yall-kvcert-cspell branch March 3, 2022 02:46
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 4, 2022
…into new_metrics_advisor

* 'main' of https://github.com/Azure/azure-sdk-for-python: (92 commits)
  [Mgmt Compute] Sanitize recordings (Azure#23331)
  [Tables] Release prep (Azure#23297)
  [Cosmos] move system_key logic to query_iterable (Azure#22893)
  [Cosmos] added additional warning to default consistency change (Azure#23225)
  update template (Azure#23333)
  [Storage] Address comments from API Review for March release (Azure#23294)
  code and test (Azure#23273)
  [textanalytics] release prep + fixing docstrings and links (Azure#23315)
  [Schema Registry] rename request kwargs to request options (Azure#23325)
  update new app service api version (Azure#23034)
  [SchemaRegistry] add tests for error codes (Azure#23140)
  Increment package version after release of azure-core (Azure#23319)
  Sync eng/common directory with azure-sdk-tools for PR 2824 (Azure#23314)
  Add python credscan in ci.yml (Azure#23307)
  [SchemaRegistry] avro api changes (Azure#23259)
  [KeyVualt KV] Fix cspell errors (Azure#23255)
  [KeyVault Certs] Fix cspell errors (Azure#23251)
  [AutoRelease] t2-containerregistry-2022-02-21-89653(Do not merge) (Azure#23155)
  [KeyVault Keys] Fix cspell errors (Azure#23250)
  Sync eng/common directory with azure-sdk-tools for PR 2830 (Azure#23267)
  ...
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants