Skip to content

Conversation

@sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Mar 3, 2022

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

The PR is to add credscan in PR

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@sima-zhu sima-zhu requested review from benbp and scbedd as code owners March 3, 2022 16:48
@sima-zhu sima-zhu requested a review from mccoyp March 3, 2022 16:49
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sima-zhu I'm confused, there was a post back on the 22nd that said this was already in. Did it just not get merged accidentally? Is this a different version of it?

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Mar 3, 2022

@scbedd It is my bad. Python did not merge this one but merged the one in aggregate-report. I missed this step. I have two PRs at the same time. The one for aggregate-report checked in and the one for PR got abandoned. I am seeing it run in my PR but not check if a new PR take the feature. Sorry for the confusion.

@sima-zhu sima-zhu merged commit 6916030 into Azure:main Mar 3, 2022
@sima-zhu sima-zhu deleted the add_cred_scan branch March 3, 2022 18:40
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 4, 2022
…into new_metrics_advisor

* 'main' of https://github.com/Azure/azure-sdk-for-python: (92 commits)
  [Mgmt Compute] Sanitize recordings (Azure#23331)
  [Tables] Release prep (Azure#23297)
  [Cosmos] move system_key logic to query_iterable (Azure#22893)
  [Cosmos] added additional warning to default consistency change (Azure#23225)
  update template (Azure#23333)
  [Storage] Address comments from API Review for March release (Azure#23294)
  code and test (Azure#23273)
  [textanalytics] release prep + fixing docstrings and links (Azure#23315)
  [Schema Registry] rename request kwargs to request options (Azure#23325)
  update new app service api version (Azure#23034)
  [SchemaRegistry] add tests for error codes (Azure#23140)
  Increment package version after release of azure-core (Azure#23319)
  Sync eng/common directory with azure-sdk-tools for PR 2824 (Azure#23314)
  Add python credscan in ci.yml (Azure#23307)
  [SchemaRegistry] avro api changes (Azure#23259)
  [KeyVualt KV] Fix cspell errors (Azure#23255)
  [KeyVault Certs] Fix cspell errors (Azure#23251)
  [AutoRelease] t2-containerregistry-2022-02-21-89653(Do not merge) (Azure#23155)
  [KeyVault Keys] Fix cspell errors (Azure#23250)
  Sync eng/common directory with azure-sdk-tools for PR 2830 (Azure#23267)
  ...
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants