Skip to content

Conversation

@swathipil
Copy link
Member

update param name

Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Mar 3, 2022

Hello @swathipil!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 486e6db into Azure:main Mar 3, 2022
@swathipil swathipil deleted the swathipil/sr/avro-rename-request-kwargs branch March 3, 2022 23:11
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 4, 2022
…into new_metrics_advisor

* 'main' of https://github.com/Azure/azure-sdk-for-python: (92 commits)
  [Mgmt Compute] Sanitize recordings (Azure#23331)
  [Tables] Release prep (Azure#23297)
  [Cosmos] move system_key logic to query_iterable (Azure#22893)
  [Cosmos] added additional warning to default consistency change (Azure#23225)
  update template (Azure#23333)
  [Storage] Address comments from API Review for March release (Azure#23294)
  code and test (Azure#23273)
  [textanalytics] release prep + fixing docstrings and links (Azure#23315)
  [Schema Registry] rename request kwargs to request options (Azure#23325)
  update new app service api version (Azure#23034)
  [SchemaRegistry] add tests for error codes (Azure#23140)
  Increment package version after release of azure-core (Azure#23319)
  Sync eng/common directory with azure-sdk-tools for PR 2824 (Azure#23314)
  Add python credscan in ci.yml (Azure#23307)
  [SchemaRegistry] avro api changes (Azure#23259)
  [KeyVualt KV] Fix cspell errors (Azure#23255)
  [KeyVault Certs] Fix cspell errors (Azure#23251)
  [AutoRelease] t2-containerregistry-2022-02-21-89653(Do not merge) (Azure#23155)
  [KeyVault Keys] Fix cspell errors (Azure#23250)
  Sync eng/common directory with azure-sdk-tools for PR 2830 (Azure#23267)
  ...
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants