-
Notifications
You must be signed in to change notification settings - Fork 448
fix: feature flags and manager state handling #5317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
5c4f87b
fix: Replace reactive feature flags with non-reactive approach
viva-jinyi 404585b
fix: Add HelpCenter manager state handling and API version switching
viva-jinyi f4fae6d
fix: Simplify manager state determination and fix API timing issues
viva-jinyi 6d1d864
fix: Correct manager state determination for non-v4 servers
viva-jinyi 13f156f
chore: Remove debug console.log statements
viva-jinyi 775faa0
test: Update manager state store tests to match new logic
viva-jinyi 6d8ed5c
fix: Remove dynamic API version handling in manager service
viva-jinyi 896eb37
refactor: Add helper functions to managerStateStore for better code r…
viva-jinyi ad29891
fix: Ensure SystemStats is loaded before conflict detection
viva-jinyi 5b6d6f1
docs: Clarify feature flag default behavior in manager state
viva-jinyi e5fb47f
fix: Ensure consistent manager state handling for legacy commands
viva-jinyi 2df02e0
refactor: centralize manager opening logic into managerStateStore
viva-jinyi fe139af
fix: use correct i18n import in managerStateStore
viva-jinyi abeed2e
feature: initial tab fix
viva-jinyi 4603ca3
test: Fix managerStateStore test failures by adding missing mocks
viva-jinyi 5de7788
refactor: convert managerStateStore to composable
viva-jinyi 4098d34
refactor: use readonly computed properties instead of getter methods
viva-jinyi dd17988
fix: check isManagerEnabled check to GraphCanvas.vue to avoid the sid…
viva-jinyi 61058a8
chore: console.log to console.debug
viva-jinyi 1bdc990
chore: useConflictDetection().initializeConflictDetection()
viva-jinyi 2386dec
test: add mockManagerDisabled option to disable manager in Playwright…
viva-jinyi aef2b7b
chore: text modified
viva-jinyi 2cadf05
fix: resolve CI/CD failures by fixing manager initialization timing
viva-jinyi 91c6c87
chore: modified the note
viva-jinyi 75db082
fix: test code modified
viva-jinyi 2b42259
fix: when manager is new manager ui, conflict detectetion should work
viva-jinyi 9634186
fix: ensure fetch system stats before determine manager stats & when …
viva-jinyi ecbb78d
chore: unnecessary .value deleted & fetch name modified to refetch
viva-jinyi 647a0f2
fix: ref type .value needed
viva-jinyi c9dd3de
chore: vue use until pattern for waiting initializing
viva-jinyi 3f2ccd8
fix: .value added
viva-jinyi a363cdc
fix: useManagerState test to properly mock reactive refs
viva-jinyi 1974b1f
fix: when system stats initialized, use until(systemStatsStore.isInit…
viva-jinyi eda2bf9
fix: test
viva-jinyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Remove dynamic API version handling in manager service
- Remove getApiBaseURL() function and axios interceptor - Always use /api/v2/ for New Manager (hardcoded) - Add isManagerServiceAvailable() to block service calls when not in NEW_UI state - Simplify API handling as manager packages are now completely separated
- Loading branch information
commit 6d8ed5c68cf14a1d189496c5eb184e55a9959623
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.