core(lightwallet): add resource-summary audit #8522
Conversation
khempenius
requested review from
brendankenny,
exterkamp,
patrickhulce and
paulirish
as code owners
khempenius
changed the title
khempenius
changed the title
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
Awesome stuff @khempenius! 🎉
You mention we're going to add a separate audit for the budgets themselves. Is the long-term plan to replace the total-byte-weight audit with this one then?
| title: 'Keep request counts and file sizes small', | ||
| /** Description of a Lighthouse audit that tells the user that they can setup a budgets for the quantity and size of page resources. No character length limits. */ | ||
| description: 'To set budgets for the quantity and size of page resources,' + | ||
| ' add a budgets.json file.', |
There was a problem hiding this comment.
I know we don't have one, but we should get a [Learn more] link in here to link up to some docs for how they adopt the json. I think users would have a hard time figuring out what to do right now.
We could start with a .md in the repo and later do some nice docs.
not blocking this PR on user docs, but let's definitely put it on the queue.
There was a problem hiding this comment.
not blocking this PR on user docs, but let's definitely put it on the queue.
how do we not have a lightwallet tracking issue? :)
added to #8331 in the meantime
| title: 'Keep request counts and file sizes small', | ||
| /** Description of a Lighthouse audit that tells the user that they can setup a budgets for the quantity and size of page resources. No character length limits. */ | ||
| description: 'To set budgets for the quantity and size of page resources,' + | ||
| ' add a budgets.json file.', |
There was a problem hiding this comment.
not blocking this PR on user docs, but let's definitely put it on the queue.
how do we not have a lightwallet tracking issue? :)
added to #8331 in the meantime
…nto lightwallet_resource_summary
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
will need to re-run yarn update:sample-json
|
the i18n description suggestions are just very quickly written suggestions, feel free to change more |
|
All changes made except updating json samples. Those keep changing, so I will do that once everything else looks good. |
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
looking good
All changes made except updating json samples. Those keep changing
yeah, it can be annoying. A number of tests use sample_v2.json, so it's hard to judge correctness until that's been updated first
| /** Imperative title of a Lighthouse audit that tells the user to minimize the size and quantity of resources used to load the page. */ | ||
| title: 'Keep request counts and transfer sizes small', | ||
| /** Description of a Lighthouse audit that tells the user that they can setup a budgets for the quantity and size of page resources. No character length limits. */ | ||
| description: 'To set budgets for the quantity and size of page resources,' + |
There was a problem hiding this comment.
sorry if I already said this but are we gonna link this up to a doc? :)
There was a problem hiding this comment.
I was planning on doing that in a separate PR once we know where that lives.
There was a problem hiding this comment.
I also added it to #8331 in the lightwallet section
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
LGTM!
(with description update?)
| /** Imperative title of a Lighthouse audit that tells the user to minimize the size and quantity of resources used to load the page. */ | ||
| title: 'Keep request counts and transfer sizes small', | ||
| /** Description of a Lighthouse audit that tells the user that they can setup a budgets for the quantity and size of page resources. No character length limits. */ | ||
| description: 'To set budgets for the quantity and size of page resources,' + |
There was a problem hiding this comment.
I also added it to #8331 in the lightwallet section
|
Description updated 👍 |
| .sort((a, b) => { | ||
| return b.size - a.size; | ||
| }); | ||
| const tableItems = otherRows.concat(thirdPartyRow); |
|
🚢 🚢 |
brendankenny
changed the title
5 participants
Summary
This implements the diagnostic portion of LightWallet.
The budgets table portion of LightWallet will be implemented as a separate audit that has a dependency on this audit.
Related Issues/PRs
#8675, #8427, #8709, #8708,#8522, #8539