lightwallet: add path support to budget #8675
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2019
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
looks great! again thank you for splitting everything up! 🙏
paulirish
reviewed
Apr 29, 2019
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
Is this a requirement for the initial launch?
I think the previous discussion was shipping with support for path: '*' only, and defining the rest later. WDYT about that?
I recommend it just because we got a lot happening at once and anything deferrable helps. :)
Collaborator
Author
|
@paulirish It's not a dire requirement, but I'd really like to see support for this ship bc I think it unlocks a lot of use important use cases around making LW easy to use with large sites. |
Contributor
|
@khempenius I'm going to close until you're starting up budgets round 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds "path" to the LightWallet budget
Related Issues/PRs
#8675, #8427, #8709, #8708,#8522, #8539