lightwallet: add 'computed/resource-summary' #8709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2019
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
looks great @khempenius thanks so much for breaking this up! made it 🍰 to review!
Collaborator
|
Also those dependency diagrams 🙏 ❤️ |
paulirish
reviewed
Apr 29, 2019
brendankenny
suggested changes
Apr 29, 2019
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
nice, this is looking great. Just some surface-level types/naming/tests comments
Contributor
|
also the LR dependency graph is amazing |
Collaborator
Author
|
Ready for review. |
Collaborator
Author
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues/PRs
#8675, #8427, #8709, #8708,#8522, #8539