Skip to content

Fix twig runtime extension last modification time detection #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stof merged 5 commits into from
Jun 13, 2025
Merged

Fix twig runtime extension last modification time detection #405

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71d6eb4
fix twig runtime extension last modification time detection
Jun 11, 2025
828ffcf
Revert "fix twig runtime extension last modification time detection"
Jun 11, 2025
b41d686
fix twig runtime extension last modification time detection
Jun 11, 2025
8364647
simplify runtime extension path detection
Jun 11, 2025
556baf0
add test
Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Knp/Menu/Twig/MenuExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ public function getTests(): array
];
}

public function getLastModified(): int
{
return max(
(int) filemtime(__FILE__),
(int) filemtime((string) (new \ReflectionClass(MenuRuntimeExtension::class))->getFileName()),
Copy link
Author

@daniser daniser Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casts added to keep Phpstan happy.

Copy link
Collaborator

@stof stof Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could simplify this by not using reflection but using __DIR__ . '/MenuRuntimeExtension.php') instead.

);
}

/**
* @param array<int, string> $path
* @param array<string, mixed> $options
Expand Down