Prepare for smart hint refactor #3470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 555d6f9979cb32e004ceb02a716d8fe11ec3d601)
Keboo
approved these changes
Mar 7, 2024
Contributor
Author
There was a problem hiding this comment.
@Keboo Yes this replaces the use of ShowMeTheXAML, because, as your previous stream also showed, that feature does not really work on the SmartHint page because most properties are dynamically added or set via an inherited style, and thus do not show up in the ShowMeTheXAML window. So I opted to use the UI real-estate for the control instead, and make this simple wrapper to allow setting some common properties in a style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the
SmartHintrefactoring, I would like to make these changes/additions to the demo app page (and a converter cleanup) in order to avoid cluttering theSmartHintrefactoring changes with a bunch of changes that are not really relevant for the changes being done.This should hopefully simplify the PR that I will eventually create when I have the
SmartHintcleaned up and working using the new approach.