Skip to content

Prepare for smart hint refactor #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keboo merged 7 commits into from
Mar 7, 2024
Merged

Prepare for smart hint refactor #3470

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e8be903
Fix return- and parameter types in VerticalAlignmentConverter
nicolaihenriksen Feb 27, 2024
6a3b3ee
Move VerticalAlignmentConverter into its own file under the Converter…
nicolaihenriksen Feb 27, 2024
bb888e2
Prepare demo app for SmartHint refactor by adding more test setting c…
nicolaihenriksen Feb 27, 2024
4074d10
Reset default demo app page back to "Home"
nicolaihenriksen Feb 27, 2024
3b61edd
Add character counter toggle to demo app
nicolaihenriksen Mar 4, 2024
dec7d77
Ensure container cannot grab keyboard focus
nicolaihenriksen Mar 5, 2024
9407c38
Remove binding errors on SmartHint demo page
nicolaihenriksen Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix return- and parameter types in VerticalAlignmentConverter
  • Loading branch information
@nicolaihenriksen
nicolaihenriksen committed Feb 27, 2024
commit e8be90343eb176fdb72d6b1be66097921baa1691
4 changes: 2 additions & 2 deletions MaterialDesignThemes.Wpf/SmartHint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,9 +241,9 @@ private void RefreshState(bool useTransitions)
public class VerticalAlignmentConverter : IValueConverter
{
public VerticalAlignment StretchReplacement { get; set; } = VerticalAlignment.Top;
public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
public object? Convert(object? value, Type targetType, object? parameter, CultureInfo culture)
=> value is VerticalAlignment.Stretch ? StretchReplacement : value;

public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
public object? ConvertBack(object? value, Type targetType, object? parameter, CultureInfo culture)
=> throw new NotImplementedException();
}