-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Prepare for smart hint refactor #3470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e8be903
Fix return- and parameter types in VerticalAlignmentConverter
nicolaihenriksen 6a3b3ee
Move VerticalAlignmentConverter into its own file under the Converter…
nicolaihenriksen bb888e2
Prepare demo app for SmartHint refactor by adding more test setting c…
nicolaihenriksen 4074d10
Reset default demo app page back to "Home"
nicolaihenriksen 3b61edd
Add character counter toggle to demo app
nicolaihenriksen dec7d77
Ensure container cannot grab keyboard focus
nicolaihenriksen 9407c38
Remove binding errors on SmartHint demo page
nicolaihenriksen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prepare demo app for SmartHint refactor by adding more test setting c…
…ontrols
- Loading branch information
commit bb888e2bc71edc7df17e40d02b968ca945300b6d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| namespace MaterialDesignDemo; | ||
|
|
||
| /// <summary> | ||
| /// ContentControl variation simply used to capture the input elements in the "Smart Hint" demo page and apply some common properties. | ||
| /// </summary> | ||
| internal class InputElementContentControl : ContentControl | ||
| { | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keboo Yes this replaces the use of ShowMeTheXAML, because, as your previous stream also showed, that feature does not really work on the SmartHint page because most properties are dynamically added or set via an inherited style, and thus do not show up in the ShowMeTheXAML window. So I opted to use the UI real-estate for the control instead, and make this simple wrapper to allow setting some common properties in a style.