feat: Convert all warnings to errors #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We try to avoid using ESLint warnings because they tend to be easy for conitrbutors to miss, and they pile up over time and make the linter miserable to work with. Our team's preference is to ignore or suppress violations that we don't want to resolve directly. We never set any rules to `warn` directly, but some of the configs ew're inheriting from include warnings. All of them have been converted to errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to avoid using ESLint warnings because they tend to be easy for conitrbutors to miss, and they pile up over time and make the linter miserable to work with. Our team's preference is to ignore or suppress violations that we don't want to resolve directly.
We never set any rules to
warndirectly, but some of the configs we're inheriting from include warnings. All of them have been converted to errors.Note
Converts specific Promise and Jest ESLint rules from warn to error and updates changelogs accordingly.
@metamask/eslint-config):error:promise/no-callback-in-promise,promise/no-nesting,promise/no-promise-in-callback,promise/no-return-in-finally,promise/valid-params.CHANGELOG.mdto note breaking changes.@metamask/eslint-config-jest):error:jest/expect-expect,jest/no-alias-methods,jest/no-commented-out-tests,jest/no-disabled-tests.CHANGELOG.mdto note breaking changes.Written by Cursor Bugbot for commit a545b6a. This will update automatically on new commits. Configure here.