Skip to content

feat: Convert all warnings to errors #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gudahtt merged 2 commits into from
Dec 2, 2025
Merged

feat: Convert all warnings to errors #424

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8a1998
feat: Convert all warnings to errors
Gudahtt Dec 2, 2025
a545b6a
Update changelog
Gudahtt Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update changelog
  • Loading branch information
@Gudahtt
Gudahtt committed Dec 2, 2025
commit a545b6ac7b5f5fad8575de0498a90c77473f021c
10 changes: 10 additions & 0 deletions packages/base/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- **BREAKING:** Convert various rules from `warn` to `error` ([#424](https://github.com/MetaMask/eslint-config/pull/424))
- The rules impacted are:
- `promise/no-callback-in-promise`
- `promise/no-nesting`
- `promise/no-promise-in-callback`
- `promise/no-return-in-finally`
- `promise/valid-params`

## [14.1.0]

### Changed
Expand Down
9 changes: 9 additions & 0 deletions packages/jest/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- **BREAKING:** Convert various rules from `warn` to `error` ([#424](https://github.com/MetaMask/eslint-config/pull/424))
- The rules impacted are:
- `jest/expect-expect`
- `jest/no-alias-methods`
- `jest/no-commented-out-tests`
- `jest/no-disabled-tests`

## [14.1.0]

### Changed
Expand Down
Loading