feat: Convert all warnings to errors

packages/base/CHANGELOG.md

@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- **BREAKING:** Convert various rules from `warn` to `error` ([#424](https://github.com/MetaMask/eslint-config/pull/424))
+  - The rules impacted are:
+    - `promise/no-callback-in-promise`
+    - `promise/no-nesting`
+    - `promise/no-promise-in-callback`
+    - `promise/no-return-in-finally`
+    - `promise/valid-params`
+
 ## [14.1.0]
 
 ### Changed

packages/base/rules-snapshot.json

@@ -3266,18 +3266,18 @@
   "promise/always-return": "error",
   "promise/avoid-new": "off",
   "promise/catch-or-return": ["error", { "allowFinally": true }],
-  "promise/no-callback-in-promise": "warn",
+  "promise/no-callback-in-promise": "error",
   "promise/no-native": "off",
-  "promise/no-nesting": "warn",
+  "promise/no-nesting": "error",
   "promise/no-new-statics": "error",
-  "promise/no-promise-in-callback": "warn",
-  "promise/no-return-in-finally": "warn",
+  "promise/no-promise-in-callback": "error",
+  "promise/no-return-in-finally": "error",
   "promise/no-return-wrap": "error",
   "promise/param-names": [
     "error",
     { "resolvePattern": "^_?resolve", "rejectPattern": "^_?reject" }
   ],
-  "promise/valid-params": "warn",
+  "promise/valid-params": "error",
   "quote-props": "off",
   "quotes": "off",
   "radix": "error",

packages/base/src/index.mjs

@@ -441,13 +441,18 @@ const rules = createConfig({
         allowFinally: true,
       },
     ],
+    'promise/no-callback-in-promise': 'error',
+    'promise/no-nesting': 'error',
+    'promise/no-promise-in-callback': 'error',
+    'promise/no-return-in-finally': 'error',
     'promise/param-names': [
       'error',
       {
         resolvePattern: '^_?resolve',
         rejectPattern: '^_?reject',
       },
     ],
+    'promise/valid-params': 'error',
   },
 });
 

packages/jest/CHANGELOG.md

@@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- **BREAKING:** Convert various rules from `warn` to `error` ([#424](https://github.com/MetaMask/eslint-config/pull/424))
+  - The rules impacted are:
+    - `jest/expect-expect`
+    - `jest/no-alias-methods`
+    - `jest/no-commented-out-tests`
+    - `jest/no-disabled-tests`
+
 ## [14.1.0]
 
 ### Changed

packages/jest/rules-snapshot.json

@@ -1,12 +1,12 @@
 {
   "@typescript-eslint/unbound-method": "off",
   "jest/consistent-test-it": ["error", { "fn": "it" }],
-  "jest/expect-expect": "warn",
-  "jest/no-alias-methods": "warn",
-  "jest/no-commented-out-tests": "warn",
+  "jest/expect-expect": "error",
+  "jest/no-alias-methods": "error",
+  "jest/no-commented-out-tests": "error",
   "jest/no-conditional-expect": "error",
   "jest/no-deprecated-functions": "error",
-  "jest/no-disabled-tests": "warn",
+  "jest/no-disabled-tests": "error",
   "jest/no-done-callback": "error",
   "jest/no-duplicate-hooks": "error",
   "jest/no-export": "error",

packages/jest/src/index.mjs

@@ -19,6 +19,10 @@ const config = createConfig([
 
     rules: {
       'jest/consistent-test-it': ['error', { fn: 'it' }],
+      'jest/expect-expect': 'error',
+      'jest/no-alias-methods': 'error',
+      'jest/no-commented-out-tests': 'error',
+      'jest/no-disabled-tests': 'error',
       'jest/no-duplicate-hooks': 'error',
       'jest/no-test-return-statement': 'error',
       'jest/prefer-hooks-on-top': 'error',