feat: Disable @typescript-eslint/no-unnecessary-type-arguments
#426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptodev-2s
approved these changes
Dec 2, 2025
Contributor
cryptodev-2s
left a comment
cryptodev-2s
left a comment
There was a problem hiding this comment.
LGTM! The reasoning make real sense.
This rule ended up getting in our way more than helping. Type arguments can sometimes be useful to include even when they're not strictly needed, so that the reader doesn't have to dig into the type definition to discover the default value. Closes #413
Gudahtt
force-pushed
the
disable-no-unnecessary-type-arguments
branch
from
f9b673c to
7a6bc7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule ended up getting in our way more than helping. Type arguments can sometimes be useful to include even when they're not strictly needed, so that the reader doesn't have to dig into the type definition to discover the default value.
Closes #413
Note
Disables the @typescript-eslint/no-unnecessary-type-arguments rule in the TypeScript ESLint config and documents the change in the changelog.
@typescript-eslint/no-unnecessary-type-argumentsinpackages/typescript/src/index.mjs(adds rationale comment).packages/typescript/rules-snapshot.jsonto set@typescript-eslint/no-unnecessary-type-argumentstooff.packages/typescript/CHANGELOG.md.Written by Cursor Bugbot for commit 7a6bc7a. This will update automatically on new commits. Configure here.