Skip to content

feat: Disable @typescript-eslint/no-unnecessary-type-arguments #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gudahtt merged 2 commits into from
Dec 2, 2025
Merged

feat: Disable @typescript-eslint/no-unnecessary-type-arguments #426

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41b8aba
feat: Disable `@typescript-eslint/no-unnecessary-type-arguments`
Gudahtt Dec 2, 2025
7a6bc7a
Update changelog
Gudahtt Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: Disable @typescript-eslint/no-unnecessary-type-arguments 
This rule ended up getting in our way more than helping. Type arguments
can sometimes be useful to include even when they're not strictly
needed, so that the reader doesn't have to dig into the type definition
to discover the default value.

Closes #413
  • Loading branch information
@Gudahtt
Gudahtt committed Dec 2, 2025
commit 41b8aba65e71de95d0bc7a9f9f2990675705d41d
2 changes: 1 addition & 1 deletion packages/typescript/rules-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"@typescript-eslint/no-this-alias": "error",
"@typescript-eslint/no-unnecessary-boolean-literal-compare": "error",
"@typescript-eslint/no-unnecessary-qualifier": "error",
"@typescript-eslint/no-unnecessary-type-arguments": "error",
"@typescript-eslint/no-unnecessary-type-arguments": "off",
"@typescript-eslint/no-unnecessary-type-assertion": "error",
"@typescript-eslint/no-unnecessary-type-constraint": "error",
"@typescript-eslint/no-unsafe-argument": "off",
Expand Down
4 changes: 3 additions & 1 deletion packages/typescript/src/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ const config = createConfig({
'@typescript-eslint/no-unsafe-enum-comparison': 'off',
'@typescript-eslint/require-await': 'off',

// Disabled because unnecessary type arguments are sometimes helpful for readability
'@typescript-eslint/no-unnecessary-type-arguments': 'off',

// Our rules that require type information
'@typescript-eslint/consistent-type-exports': 'error',
'@typescript-eslint/naming-convention': [
Expand Down Expand Up @@ -152,7 +155,6 @@ const config = createConfig({
'@typescript-eslint/no-meaningless-void-operator': 'error',
'@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
'@typescript-eslint/no-unnecessary-qualifier': 'error',
'@typescript-eslint/no-unnecessary-type-arguments': 'error',
'@typescript-eslint/prefer-enum-initializers': 'error',
'@typescript-eslint/prefer-includes': 'error',
'@typescript-eslint/prefer-nullish-coalescing': 'error',
Expand Down