[aspnetcore] Feature/cleanup

[A-Joshi]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Mostly cosmetic code refactoring to make the code more readable - as per 2285

• Make classModifier, operationModifier and buildTarget enums
• Enhance CliOption class to hold value - it reduces boilerplat code.
• Add ASP.Net Core 2.2 (no changes to generated code - since it is pretty much backward compatible with 2.1).

[wing328]

cc @jimschubert as this PR enhances the CliOption class.

[wing328]

@A-Joshi thanks for the PR. Just a heads up that there's another project to add a ASP.NET core 3.0 generator: https://github.com/OpenAPITools/openapi-generator/projects/9

[A-Joshi]

Thanks will reach out - it should be easy to add in the 3.0 support as a folder and target to the current setup so we don't have yet another almost the same generator

…

On 3/19/19 9:48 AM, William Cheng wrote: @A-Joshi <https://github.com/A-Joshi> thanks for the PR. Just a heads up that there's another project to add a ASP.NET core 3.0 generator: https://github.com/OpenAPITools/openapi-generator/projects/9 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2436 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANQEIS3a8j48pVZqsilUaQ6JnUJpKN_jks5vYOq6gaJpZM4b5tfg>.

[wing328]

I've not tried 3.0 myself. Is that very different when compared with the 2.x version?

For other generators (e.g. Swift), we deal with major version upgrade with a new generator to make it easier to maintain.

For ASP.NET CORE, I do not have a preference as I'm not familiar with the framework.

[A-Joshi]

So far the changes are mostly for performance and some thirdparty packages have been removed. I'll reach out to see what would work best.

…

On 3/19/19 10:50 AM, William Cheng wrote: I've not tried 3.0 myself. Is that very different when compared with the 2.x version? For other generators (e.g. Swift), we deal with major version upgrade with a new generator to make it easier to maintain. For ASP.NET CORE, I do not have a preference as I'm not familiar with the framework. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2436 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANQEIWSSRF2X9eKWDxeoy8aDHF3nbGgpks5vYPlLgaJpZM4b5tfg>.

[wing328]

Looks like a rebase fails and this PR now contains commits not authored by you.

I wonder if you can create a new branch based on the latest master and cherry-pick your commits.

[jimschubert]

Changes look good. I've rebased onto my own branch to evaluate only the changes related to this PR. Feel free to pull/branch off that and reopen a PR: https://github.com/jimschubert/openapi-generator/tree/ihsmarkitoss-feature/cleanup. Probably best to have @A-Joshi double-check just to make sure I didn't accidentally remove any intended work during the rebase.

[jimschubert]

I'm closing this in favor of #2506, which is rebased against master and includes original contributor information during the rebase.

[A-Joshi]

Thanks have been traveling abroad will look as soon as I am back this week

…

On Tue, Mar 26, 2019, 3:42 AM Jim Schubert ***@***.***> wrote: Closed #2436 <#2436> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2436 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANQEIXK1fln0-tg_2FHdn9oPY-YRIjaIks5vaYj_gaJpZM4b5tfg> .