Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
34df1fd
feat(node): add per-IP write-surface rate brake and apply to write_ro…
beardthelion Jul 13, 2026
74e05be
feat(node): extend the per-IP write brake to the remaining write sinks
beardthelion Jul 13, 2026
6fded6e
test(node): adversarial TrustedProxy verification through the write b…
beardthelion Jul 13, 2026
e6324d2
feat(node): purge-spam admin subcommand for the empty-burst cleanup
beardthelion Jul 13, 2026
285d7c7
fix(review): make purge-spam empty-check reject git-discovery reads
beardthelion Jul 13, 2026
090019d
fix(review): normalization-consistent purge, brake helper, CLI + cove…
beardthelion Jul 13, 2026
dfd4f6c
test(review): close the reasoned-not-run gaps by execution
beardthelion Jul 13, 2026
0135419
fix(node): reject path-traversal repo names in purge-spam before remo…
beardthelion Jul 15, 2026
a0fcbb0
fix(node): delete child rows transactionally in delete_repo_by_id
beardthelion Jul 15, 2026
fde9cfe
fix(node): reap write_rate_limiter in the periodic cleanup loop
beardthelion Jul 15, 2026
15522d5
fix(node): hold the per-repo advisory lock across purge recheck+delete
beardthelion Jul 15, 2026
1fcca0d
fix(node): count purge-spam disk-removal failures separately from del…
beardthelion Jul 15, 2026
d9eebd2
fix(node): warn on unparseable rate-limit env vars instead of silentl…
beardthelion Jul 15, 2026
6325402
docs(node): document GITLAWB_IPFS_API/TIGRIS_BUCKET/METRICS_ADDR/SHUT…
beardthelion Jul 15, 2026
bfbe502
test(node): exercise the dry-run guard with a real on-disk candidate …
beardthelion Jul 15, 2026
cdb102e
style(node): cargo fmt for the #196 fix set
beardthelion Jul 15, 2026
4df79f2
fix(node): pin the writer's advisory-lock connection in RepoWriteGuard
beardthelion Jul 15, 2026
68c1f5c
refactor(node): introduce ObjectStore trait seam over TigrisClient
beardthelion Jul 15, 2026
3c1ceb8
fix(node): make purge-spam Tigris-authoritative and archive-deleting
beardthelion Jul 15, 2026
cf669bb
fix(review): don't hold/leak the pool connection in acquire_write
beardthelion Jul 15, 2026
dde5ea9
fix(node): make advisory-lock guards drop-safe and reorder acquire_write
beardthelion Jul 16, 2026
b94d440
fix(node): complete a fully-received push after client disconnect
beardthelion Jul 16, 2026
e4c4161
fix(node): serialize archive uploads under the per-repo advisory lock
beardthelion Jul 16, 2026
6ba698c
fix(node): let purge-spam reach repos that exist only as archives
beardthelion Jul 16, 2026
9f7757c
refactor(node): dedup limiter setup + write-brake test driver; fix .e…
beardthelion Jul 16, 2026
2a78524
docs(node): drop the .env.example shutdown-grace entry #196 added (#196)
beardthelion Jul 19, 2026
c4b337b
fix(node): give advisory-lock guards a dedicated pool and bound the r…
beardthelion Jul 19, 2026
4934646
fix(node): advertise a window-derived Retry-After on rate-limit 429s …
beardthelion Jul 19, 2026
0c279c9
fix(node): skip slug-scoped purge cascade when a mirror row shares th…
beardthelion Jul 19, 2026
86a8228
fix(node): fail closed classifying the purge target directory (#196)
beardthelion Jul 20, 2026
bf2a54e
fix(node): run the push completion tail in the disconnect-surviving t…
beardthelion Jul 20, 2026
c24b541
fix(node): tombstone bounties when their repo is purged (#196)
beardthelion Jul 20, 2026
3baa9ed
fix(node): serialize create_repo against the purge advisory lock (#196)
beardthelion Jul 20, 2026
9916bca
test(node): prove purge deletes at MAX_CONNECTIONS=1 with the split p…
beardthelion Jul 20, 2026
8f3d643
fix(node): fail the push when the durable upload times out, don't 200…
beardthelion Jul 20, 2026
d1e596e
fix(node): tombstone bounties under both owner forms on purge (#196)
beardthelion Jul 20, 2026
ce5dcc3
fix(node): fail closed on a symlink at the purge target (#196)
beardthelion Jul 20, 2026
7dc7be2
fix(node): retry-after on the push-advert 429, and create_repo locks …
beardthelion Jul 20, 2026
d2ba14e
fix(node): correct the create-pool and bounty-tombstone remediations …
beardthelion Jul 20, 2026
5a46ef6
fix(node): close the durable-upload data-loss class on every write pa…
beardthelion Jul 20, 2026
2fa9fa3
chore: merge main (iCaptcha PoW + gl retry tests) into feat/write-sin…
beardthelion Jul 21, 2026
16517f8
refactor(node): route the per-DID 429 through the shared too_many_req…
beardthelion Jul 21, 2026
ba572b3
fix(node): init's background upload waits out the creator's advisory …
beardthelion Jul 21, 2026
859240b
fix(node): roll back the local issue ref before unlock when the durab…
beardthelion Jul 21, 2026
c07435d
fix(node): fork publishes only after a durable upload, serialized on …
beardthelion Jul 21, 2026
2ad1c79
fix(node): read-path downloads publish under the purge lock, without …
beardthelion Jul 21, 2026
b2ca5a7
fix(node): bound every under-lock object-store call and dedup the upl…
beardthelion Jul 21, 2026
fa4322c
fix(node): harden the read-path download against cancellation, stale …
beardthelion Jul 21, 2026
c3d6e73
fix(node): keep the fork's unbounded work out of the target-lock span…
beardthelion Jul 21, 2026
03ef9b5
refactor(node): move read-path download coordination into a repo_stor…
beardthelion Jul 21, 2026
4408d27
fix(node): bound acquire_write's download and free the download-map e…
beardthelion Jul 21, 2026
a12f21a
fix(node): roll back the fork mirror and archive on late clone/insert…
beardthelion Jul 21, 2026
556aa31
fix(node): serialize repo purge cascade with mirror ingest via adviso…
beardthelion Jul 22, 2026
1d8c281
fix(node): roll back local ref on failed durable upload (close/merge/…
beardthelion Jul 22, 2026
1d0d3d2
fix(node): tie cancelled cold-download cleanup to blocking extraction
beardthelion Jul 22, 2026
03cd81e
chore(node): fmt + clippy cleanup for the #196 fixes
beardthelion Jul 22, 2026
9152178
fix(node): never let a failed ref snapshot become a delete-all rollba…
beardthelion Jul 22, 2026
296704f
fix(node): slug-lock every peer-ingest writer and drive the real inge…
beardthelion Jul 22, 2026
1e79ae5
fix(node): own cold-download cleanup in a spawned task so handler can…
beardthelion Jul 22, 2026
ce25bba
refactor(node): delegate issue ref helpers to the store ref primitives
beardthelion Jul 22, 2026
4329b2a
Merge origin/main into feat/write-sink-brake-coverage (reintegrate cu…
beardthelion Jul 22, 2026
d755180
fix(node): slug-lock arweave anchor writes; fail closed when the pre-…
beardthelion Jul 22, 2026
e6f4b2f
fix(node): close review residuals: coalesce cold downloads to one in-…
beardthelion Jul 22, 2026
1459cf2
Merge remote-tracking branch 'origin/main' into feat/write-sink-brake…
beardthelion Nov 11, 2026
da876e8
fix(node): re-apply create/fork purge serialization and restore brake…
beardthelion Nov 11, 2026
edfa6bb
fix(node): close review gaps in purge, locks, and fork cleanup
beardthelion Nov 11, 2026
96ed2b2
fix(node): subscriptions-only ws schema and unsettled-work purge guard
beardthelion Nov 11, 2026
082a37f
Merge remote-tracking branch 'origin/main' into feat/write-sink-brake…
beardthelion Nov 11, 2026
e9e86a1
fix(node): wire close_issue rollback, close purge symlink gap, correc…
beardthelion Nov 11, 2026
1187dca
fix(node): close purge/upload lifecycle gaps from review
beardthelion Nov 11, 2026
261f7ab
fix(node): merge rollback, honest create rollback, purge row recheck
beardthelion Nov 12, 2026
662b9a3
fix(node): probe purge slug liveness, gate issue write brake behind t…
beardthelion Nov 12, 2026
43d4f59
fix(node): close-issue rollback uses resolved ref, drop router brake …
beardthelion Nov 12, 2026
4b483a3
fix(node): close_issue spends neither bucket when either cap refuses,…
beardthelion Nov 12, 2026
11cadb9
fix(node): refund the write slot when the close cap refuses, send Ret…
beardthelion Nov 12, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(node): tie cancelled cold-download cleanup to blocking extraction
On a download timeout the TempDownloadDir guard dropped while the detached
spawn_blocking extraction kept running and could rename its output back into
the just-removed temp path; that dir was only reclaimed on a later same-repo
request, so cold reads across distinct repos accumulated extracted repos on
disk. The timeout arm now hands the owned download future to a detached janitor
that awaits extraction completion before removing the temp dir, off the
critical path so waiters are still freed immediately. (F3, #196)
  • Loading branch information
beardthelion committed Jul 22, 2026
commit 1d0d3d2dcad2a03e5a1e2f1360523d53532871c5
103 changes: 103 additions & 0 deletions crates/gitlawb-node/src/git/repo_store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2680,4 +2680,107 @@ mod tests {
"a cold-read future cancelled mid-download must still free its map entry"
);
}

// ── F3: a timed-out cold read must not resurrect its abandoned temp dir ──

// An ObjectStore double that reproduces the detached-spawn_blocking
// resurrection. Its download() runs the extraction in spawn_blocking (as the
// real TigrisClient::download does) and awaits the join handle. A tokio
// timeout that fires while the blocking task runs does NOT cancel it:
// dropping the download future detaches the task, which then creates ("renames
// into place") the target path LATE — after the caller's temp-dir cleanup has
// already run. `extracted` is bumped once the blocking task has created the
// dir, so a test can wait for the extraction to actually land.
struct DetachExtractStore {
extract_delay: std::time::Duration,
downloads: std::sync::Arc<std::sync::atomic::AtomicUsize>,
extracted: std::sync::Arc<std::sync::atomic::AtomicUsize>,
}

#[async_trait::async_trait]
impl crate::git::tigris::ObjectStore for DetachExtractStore {
async fn exists(&self, _o: &str, _r: &str) -> anyhow::Result<bool> {
Ok(true)
}
async fn upload(&self, _o: &str, _r: &str, _p: &std::path::Path) -> anyhow::Result<()> {
Ok(())
}
async fn download(&self, _o: &str, _r: &str, p: &std::path::Path) -> anyhow::Result<()> {
self.downloads
.fetch_add(1, std::sync::atomic::Ordering::SeqCst);
let target = p.to_path_buf();
let delay = self.extract_delay;
let extracted = self.extracted.clone();
// Mirror TigrisClient::download: the extraction runs in spawn_blocking
// and we await the join. A timeout that drops THIS future detaches the
// blocking task, which finishes its "rename into place" after cleanup.
tokio::task::spawn_blocking(move || {
std::thread::sleep(delay);
std::fs::create_dir_all(&target).unwrap();
// A marker so the resurrected dir looks like a real extraction.
std::fs::write(target.join("HEAD"), b"ref: refs/heads/main\n").unwrap();
extracted.fetch_add(1, std::sync::atomic::Ordering::SeqCst);
})
.await
.unwrap();
Ok(())
}
async fn delete(&self, _o: &str, _r: &str) -> anyhow::Result<()> {
Ok(())
}
}

// F3: a cold read whose download times out must not let the detached
// spawn_blocking extraction resurrect the abandoned temp dir after cleanup.
// The store's extraction lands well past the download timeout; the timeout
// fires, acquire bails, and the extraction then creates ("renames into place")
// temp.path(). The fix ties cleanup to the extraction's completion — a
// detached janitor awaits the download future to settle, then removes the temp
// dir — so no `.tmp-download.*` dir survives. Pre-fix the timeout arm drops the
// download future, the detached extraction recreates temp.path() AFTER the RAII
// guard's Drop, and it survives forever — the second poll never sees a clean
// parent -> RED.
#[sqlx::test]
async fn timed_out_cold_read_does_not_resurrect_temp_dir(pool: sqlx::PgPool) {
use std::sync::atomic::Ordering::SeqCst;
let tmp = tempfile::TempDir::new().unwrap();
let extracted = std::sync::Arc::new(std::sync::atomic::AtomicUsize::new(0));
let downloads = std::sync::Arc::new(std::sync::atomic::AtomicUsize::new(0));
let ts = DetachExtractStore {
// The extraction lands well after the 150ms download timeout below.
extract_delay: std::time::Duration::from_millis(600),
downloads: downloads.clone(),
extracted: extracted.clone(),
};
let store = RepoStore::new(tmp.path().to_path_buf(), Some(std::sync::Arc::new(ts)), pool)
.with_release_upload_timeout(std::time::Duration::from_millis(150));
let owner = "did:key:z6MkF3ResurrectTempDirAAAAAAAAAAAAAAAAAAAA";
let name = "f3resurrect";
let dir = repo_dir_of(tmp.path(), owner, name);
let parent = dir.parent().unwrap().to_path_buf();

// Cold cache miss: acquire enters the download path, the download times out
// at 150ms, and the read path bails (no local copy to serve).
let res = store.acquire(owner, name).await;
assert!(
res.is_err(),
"a timed-out cold read with no local copy must bail"
);
assert_eq!(downloads.load(SeqCst), 1, "exactly one download attempt");

// Wait for the detached extraction to actually finish its "rename into
// place" (the resurrection moment).
assert!(
poll_until_true(|| extracted.load(SeqCst) >= 1).await,
"the detached extraction must run to completion"
);

// Once the extraction has landed, no temp dir may survive under the parent.
// The fix's janitor removes temp.path() after the extraction settles;
// pre-fix the resurrected dir survives and this poll never sees it cleaned.
assert!(
poll_until_true(|| !has_leftover_temp(&parent)).await,
"a timed-out cold read must not leave a resurrected .tmp-download.* dir"
);
}
}
43 changes: 37 additions & 6 deletions crates/gitlawb-node/src/git/repo_store/download.rs
Original file line number Diff line number Diff line change
Expand Up @@ -233,17 +233,48 @@ impl RepoStore {
// A timeout takes the SAME cleanup arm as a download error (return Err,
// the temp guard's Drop removes the dir), so `download_published` frees
// the map entry and wakes waiters rather than leaving them parked forever.
match tokio::time::timeout(
self.release_upload_timeout,
store.download(owner_slug, repo_name, temp.path()),
)
.await
{
//
// The download future is OWNED (Box::pin) rather than borrowed so the
// timeout arm can hand the still-running extraction to a detached janitor
// instead of dropping it (finding F3). `store.download` runs its tar
// extraction in `spawn_blocking`, and a tokio timeout does NOT cancel a
// spawn_blocking task: dropping the download future on timeout detaches
// that task, which then renames its extraction into `temp.path()` AFTER
// this function's `temp` guard Drop has already removed the dir —
// resurrecting an abandoned, fully-populated temp dir that the per-repo
// sweep above only reclaims on a later download of the SAME repo, so an
// abandoned extraction for a repo never re-downloaded accumulates on disk.
let store_dl = Arc::clone(store);
let (dl_owner, dl_repo, dl_target) = (
owner_slug.to_string(),
repo_name.to_string(),
temp.path().to_path_buf(),
);
let mut download_fut =
Box::pin(async move { store_dl.download(&dl_owner, &dl_repo, &dl_target).await });
match tokio::time::timeout(self.release_upload_timeout, &mut download_fut).await {
Ok(Ok(())) => {}
Ok(Err(e)) => return Err(e),
Err(_) => {
warn!(repo = %repo_name, timeout_secs = self.release_upload_timeout.as_secs(),
"read download timed out — discarding");
// Do NOT drop the download future here: its spawn_blocking
// extraction may still be running, and dropping detaches it,
// letting its rename resurrect `temp.path()` after cleanup. Tie
// cleanup to the extraction's completion instead — disarm the RAII
// guard and hand the future to a detached janitor that awaits it
// to settle (the spawn_blocking join resolves, so any rename has
// landed) and only THEN removes the temp dir. Waiters are freed
// immediately by the return below; the janitor runs off the
// critical path, bounded by the extraction itself.
let temp_path = temp.path().to_path_buf();
temp.disarm();
tokio::spawn(async move {
let _ = download_fut.await;
let _ =
tokio::task::spawn_blocking(move || std::fs::remove_dir_all(&temp_path))
.await;
});
return Err(anyhow::anyhow!("read download timed out"));
}
}
Expand Down