Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
34df1fd
feat(node): add per-IP write-surface rate brake and apply to write_ro…
beardthelion Jul 13, 2026
74e05be
feat(node): extend the per-IP write brake to the remaining write sinks
beardthelion Jul 13, 2026
6fded6e
test(node): adversarial TrustedProxy verification through the write b…
beardthelion Jul 13, 2026
e6324d2
feat(node): purge-spam admin subcommand for the empty-burst cleanup
beardthelion Jul 13, 2026
285d7c7
fix(review): make purge-spam empty-check reject git-discovery reads
beardthelion Jul 13, 2026
090019d
fix(review): normalization-consistent purge, brake helper, CLI + cove…
beardthelion Jul 13, 2026
dfd4f6c
test(review): close the reasoned-not-run gaps by execution
beardthelion Jul 13, 2026
0135419
fix(node): reject path-traversal repo names in purge-spam before remo…
beardthelion Jul 15, 2026
a0fcbb0
fix(node): delete child rows transactionally in delete_repo_by_id
beardthelion Jul 15, 2026
fde9cfe
fix(node): reap write_rate_limiter in the periodic cleanup loop
beardthelion Jul 15, 2026
15522d5
fix(node): hold the per-repo advisory lock across purge recheck+delete
beardthelion Jul 15, 2026
1fcca0d
fix(node): count purge-spam disk-removal failures separately from del…
beardthelion Jul 15, 2026
d9eebd2
fix(node): warn on unparseable rate-limit env vars instead of silentl…
beardthelion Jul 15, 2026
6325402
docs(node): document GITLAWB_IPFS_API/TIGRIS_BUCKET/METRICS_ADDR/SHUT…
beardthelion Jul 15, 2026
bfbe502
test(node): exercise the dry-run guard with a real on-disk candidate …
beardthelion Jul 15, 2026
cdb102e
style(node): cargo fmt for the #196 fix set
beardthelion Jul 15, 2026
4df79f2
fix(node): pin the writer's advisory-lock connection in RepoWriteGuard
beardthelion Jul 15, 2026
68c1f5c
refactor(node): introduce ObjectStore trait seam over TigrisClient
beardthelion Jul 15, 2026
3c1ceb8
fix(node): make purge-spam Tigris-authoritative and archive-deleting
beardthelion Jul 15, 2026
cf669bb
fix(review): don't hold/leak the pool connection in acquire_write
beardthelion Jul 15, 2026
dde5ea9
fix(node): make advisory-lock guards drop-safe and reorder acquire_write
beardthelion Jul 16, 2026
b94d440
fix(node): complete a fully-received push after client disconnect
beardthelion Jul 16, 2026
e4c4161
fix(node): serialize archive uploads under the per-repo advisory lock
beardthelion Jul 16, 2026
6ba698c
fix(node): let purge-spam reach repos that exist only as archives
beardthelion Jul 16, 2026
9f7757c
refactor(node): dedup limiter setup + write-brake test driver; fix .e…
beardthelion Jul 16, 2026
2a78524
docs(node): drop the .env.example shutdown-grace entry #196 added (#196)
beardthelion Jul 19, 2026
c4b337b
fix(node): give advisory-lock guards a dedicated pool and bound the r…
beardthelion Jul 19, 2026
4934646
fix(node): advertise a window-derived Retry-After on rate-limit 429s …
beardthelion Jul 19, 2026
0c279c9
fix(node): skip slug-scoped purge cascade when a mirror row shares th…
beardthelion Jul 19, 2026
86a8228
fix(node): fail closed classifying the purge target directory (#196)
beardthelion Jul 20, 2026
bf2a54e
fix(node): run the push completion tail in the disconnect-surviving t…
beardthelion Jul 20, 2026
c24b541
fix(node): tombstone bounties when their repo is purged (#196)
beardthelion Jul 20, 2026
3baa9ed
fix(node): serialize create_repo against the purge advisory lock (#196)
beardthelion Jul 20, 2026
9916bca
test(node): prove purge deletes at MAX_CONNECTIONS=1 with the split p…
beardthelion Jul 20, 2026
8f3d643
fix(node): fail the push when the durable upload times out, don't 200…
beardthelion Jul 20, 2026
d1e596e
fix(node): tombstone bounties under both owner forms on purge (#196)
beardthelion Jul 20, 2026
ce5dcc3
fix(node): fail closed on a symlink at the purge target (#196)
beardthelion Jul 20, 2026
7dc7be2
fix(node): retry-after on the push-advert 429, and create_repo locks …
beardthelion Jul 20, 2026
d2ba14e
fix(node): correct the create-pool and bounty-tombstone remediations …
beardthelion Jul 20, 2026
5a46ef6
fix(node): close the durable-upload data-loss class on every write pa…
beardthelion Jul 20, 2026
2fa9fa3
chore: merge main (iCaptcha PoW + gl retry tests) into feat/write-sin…
beardthelion Jul 21, 2026
16517f8
refactor(node): route the per-DID 429 through the shared too_many_req…
beardthelion Jul 21, 2026
ba572b3
fix(node): init's background upload waits out the creator's advisory …
beardthelion Jul 21, 2026
859240b
fix(node): roll back the local issue ref before unlock when the durab…
beardthelion Jul 21, 2026
c07435d
fix(node): fork publishes only after a durable upload, serialized on …
beardthelion Jul 21, 2026
2ad1c79
fix(node): read-path downloads publish under the purge lock, without …
beardthelion Jul 21, 2026
b2ca5a7
fix(node): bound every under-lock object-store call and dedup the upl…
beardthelion Jul 21, 2026
fa4322c
fix(node): harden the read-path download against cancellation, stale …
beardthelion Jul 21, 2026
c3d6e73
fix(node): keep the fork's unbounded work out of the target-lock span…
beardthelion Jul 21, 2026
03ef9b5
refactor(node): move read-path download coordination into a repo_stor…
beardthelion Jul 21, 2026
4408d27
fix(node): bound acquire_write's download and free the download-map e…
beardthelion Jul 21, 2026
a12f21a
fix(node): roll back the fork mirror and archive on late clone/insert…
beardthelion Jul 21, 2026
556aa31
fix(node): serialize repo purge cascade with mirror ingest via adviso…
beardthelion Jul 22, 2026
1d8c281
fix(node): roll back local ref on failed durable upload (close/merge/…
beardthelion Jul 22, 2026
1d0d3d2
fix(node): tie cancelled cold-download cleanup to blocking extraction
beardthelion Jul 22, 2026
03cd81e
chore(node): fmt + clippy cleanup for the #196 fixes
beardthelion Jul 22, 2026
9152178
fix(node): never let a failed ref snapshot become a delete-all rollba…
beardthelion Jul 22, 2026
296704f
fix(node): slug-lock every peer-ingest writer and drive the real inge…
beardthelion Jul 22, 2026
1e79ae5
fix(node): own cold-download cleanup in a spawned task so handler can…
beardthelion Jul 22, 2026
ce25bba
refactor(node): delegate issue ref helpers to the store ref primitives
beardthelion Jul 22, 2026
4329b2a
Merge origin/main into feat/write-sink-brake-coverage (reintegrate cu…
beardthelion Jul 22, 2026
d755180
fix(node): slug-lock arweave anchor writes; fail closed when the pre-…
beardthelion Jul 22, 2026
e6f4b2f
fix(node): close review residuals: coalesce cold downloads to one in-…
beardthelion Jul 22, 2026
1459cf2
Merge remote-tracking branch 'origin/main' into feat/write-sink-brake…
beardthelion Nov 11, 2026
da876e8
fix(node): re-apply create/fork purge serialization and restore brake…
beardthelion Nov 11, 2026
edfa6bb
fix(node): close review gaps in purge, locks, and fork cleanup
beardthelion Nov 11, 2026
96ed2b2
fix(node): subscriptions-only ws schema and unsettled-work purge guard
beardthelion Nov 11, 2026
082a37f
Merge remote-tracking branch 'origin/main' into feat/write-sink-brake…
beardthelion Nov 11, 2026
e9e86a1
fix(node): wire close_issue rollback, close purge symlink gap, correc…
beardthelion Nov 11, 2026
1187dca
fix(node): close purge/upload lifecycle gaps from review
beardthelion Nov 11, 2026
261f7ab
fix(node): merge rollback, honest create rollback, purge row recheck
beardthelion Nov 12, 2026
662b9a3
fix(node): probe purge slug liveness, gate issue write brake behind t…
beardthelion Nov 12, 2026
43d4f59
fix(node): close-issue rollback uses resolved ref, drop router brake …
beardthelion Nov 12, 2026
4b483a3
fix(node): close_issue spends neither bucket when either cap refuses,…
beardthelion Nov 12, 2026
11cadb9
fix(node): refund the write slot when the close cap refuses, send Ret…
beardthelion Nov 12, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(node): fail the push when the durable upload times out, don't 200 (…
…#196)

The bounded release() upload (from the lock-pool fix) abandoned a slow
PUT, freed the lock, and returned no failure signal, so receive-pack
reported 200 while the archive never reached object storage — and the
next acquire_write downloaded the stale pre-push archive over local
disk, reverting the pushed refs. A timed-out or errored durable upload
now returns upload_ok=false; the handler sends a 5xx and skips the
success tail so the client re-pushes idempotently instead of trusting a
lost commit. The lock still frees on every path and the connection-hold
bound is unchanged.
  • Loading branch information
beardthelion committed Jul 20, 2026
commit 8f3d643a721e7259ab80d2b2531737c773b01272
184 changes: 183 additions & 1 deletion crates/gitlawb-node/src/api/repos.rs
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ pub async fn git_receive_pack(
// to prevent stale locks and to avoid holding the write lock across the
// fan-out. Only upload to Tigris when the push succeeded; uploading a
// half-applied repo would propagate corruption.
guard.release(result.is_ok()).await;
let upload_ok = guard.release(result.is_ok()).await;

// On receive-pack error, deliver the classified error to the client and run
// NO tail. On success, hand report-status to the client now, then continue
Expand All @@ -1011,6 +1011,24 @@ pub async fn git_receive_pack(
return;
}
};

// The refs applied locally, but the durable upload to object storage
// FAILED or timed out. Report the push as failed (5xx) instead of 200 so
// the idempotent client re-pushes and re-uploads: otherwise the next
// acquire_write downloads the STALE pre-push archive over local disk and
// reverts these refs, silently losing the commit the client believes it
// landed. Skip the whole success tail — a push whose durable copy never
// landed must not be recorded/broadcast as accepted. (P1 data-loss fix.)
if !upload_ok {
tracing::error!(repo = %record.name,
"durable upload failed after receive-pack — reporting push failure so the client retries");
let _ = report_tx.send(Err(AppError::Git(format!(
"durable storage upload failed for {}",
record.name
))));
return;
}

let _ = report_tx.send(Ok(response));

// Update the repo's updated_at timestamp after a successful push
Expand Down Expand Up @@ -3095,6 +3113,170 @@ mod tests {
assert_eq!(pushes, 1, "the tail must run on a connected push too");
}

// P1 data-loss regression: when the durable (Tigris) upload in release()
// times out, the refs are applied on local disk but never persisted to
// object storage. The pre-fix handler still reported 200 to the client AND
// ran the success tail, so the client trusted a push that the NEXT
// acquire_write would revert from the stale pre-push archive — silent data
// loss. The fix surfaces a failed/timed-out upload as a FAILED push (5xx) so
// the idempotent client re-pushes, and skips the whole success tail. Here we
// stall the upload past a tiny release timeout, drive a fully-applied push,
// and assert (a) the client gets a non-2xx and (b) the tail did NOT run
// (no push record). RED pre-fix: 200 + push record present.
#[sqlx::test]
async fn durable_upload_timeout_fails_push_and_skips_tail(pool: sqlx::PgPool) {
use axum::extract::{Path as AxPath, State};
use axum::response::IntoResponse;
use axum::Extension;
use std::path::Path as StdPath;
use std::process::{Command, Stdio};
use std::time::Duration;

// Object store whose upload() parks forever: the release() timeout is the
// only thing that unblocks it. `exists()` is false so acquire_write never
// downloads over the fresh local bare repo.
struct StallStore;
#[async_trait::async_trait]
impl crate::git::tigris::ObjectStore for StallStore {
async fn exists(&self, _o: &str, _r: &str) -> anyhow::Result<bool> {
Ok(false)
}
async fn upload(&self, _o: &str, _r: &str, _p: &StdPath) -> anyhow::Result<()> {
std::future::pending::<()>().await;
Ok(())
}
async fn download(&self, _o: &str, _r: &str, _p: &StdPath) -> anyhow::Result<()> {
Ok(())
}
async fn delete(&self, _o: &str, _r: &str) -> anyhow::Result<()> {
Ok(())
}
}

let mut state = crate::test_support::test_state(pool.clone()).await;
let repos_dir = tempfile::TempDir::new().unwrap();
state.repo_store = crate::git::repo_store::RepoStore::new(
repos_dir.path().to_path_buf(),
Some(std::sync::Arc::new(StallStore)),
pool.clone(),
)
.with_release_upload_timeout(Duration::from_millis(200));

let owner = "z6durablefailowner";
let name = "durablefail";
let owner_slug = owner.replace([':', '/'], "_");
let bare = repos_dir
.path()
.join(&owner_slug)
.join(format!("{name}.git"));

state
.db
.upsert_mirror_repo(owner, name, &bare.to_string_lossy(), None, false)
.await
.unwrap();

fn git(args: &[&str], dir: &std::path::Path) -> String {
let out = Command::new("git")
.args(args)
.current_dir(dir)
.output()
.unwrap();
assert!(
out.status.success(),
"git {args:?} failed: {}",
String::from_utf8_lossy(&out.stderr)
);
String::from_utf8_lossy(&out.stdout).trim().to_string()
}

let work = tempfile::TempDir::new().unwrap();
git(&["init", "-q", "-b", "main", "."], work.path());
git(&["config", "user.email", "t@t"], work.path());
git(&["config", "user.name", "t"], work.path());
std::fs::write(work.path().join("f.txt"), "hi").unwrap();
git(&["add", "f.txt"], work.path());
git(&["commit", "-q", "-m", "c"], work.path());
let oid = git(&["rev-parse", "HEAD"], work.path());

std::fs::create_dir_all(bare.parent().unwrap()).unwrap();
let out = Command::new("git")
.args([
"clone",
"--bare",
"-q",
&work.path().to_string_lossy(),
&bare.to_string_lossy(),
])
.output()
.unwrap();
assert!(out.status.success(), "clone --bare failed");
git(
&[
"-C",
&bare.to_string_lossy(),
"update-ref",
"-d",
"refs/heads/main",
],
work.path(),
);

// No hook: the push applies immediately; the stall is entirely in release().
let zero = "0".repeat(40);
let cmd = format!("{zero} {oid} refs/heads/main\0report-status\n");
let mut body = Vec::new();
let len = cmd.len() + 4;
body.extend_from_slice(format!("{len:04x}").as_bytes());
body.extend_from_slice(cmd.as_bytes());
body.extend_from_slice(b"0000");
let pack = Command::new("git")
.args([
"-C",
&bare.to_string_lossy(),
"pack-objects",
"--stdout",
"-q",
])
.stdin(Stdio::null())
.output()
.unwrap();
assert!(pack.status.success(), "pack-objects failed");
body.extend_from_slice(&pack.stdout);
let body = Bytes::from(body);

// Await the handler: acquire → receive-pack (applies) → release (upload
// stalls, timing out after 200ms). The client MUST see a failure, not 200.
let resp = super::git_receive_pack(
State(state.clone()),
AxPath((owner.to_string(), format!("{name}.git"))),
Extension(crate::auth::AuthenticatedDid(owner.to_string())),
body,
)
.await;
let status = match resp {
Ok(r) => r.status(),
Err(e) => e.into_response().status(),
};
assert!(
status.is_server_error(),
"a timed-out durable upload must fail the push (5xx) so the client \
retries — got {status}, which the client trusts as a landed push \
that a later acquire_write would silently revert"
);

// And the success tail must NOT have run: no push record for a push whose
// durable copy never landed. Give the (detached) tail time to run if it
// were going to, then assert it did not.
tokio::time::sleep(Duration::from_millis(400)).await;
let pushes = state.db.get_push_count(owner).await.unwrap();
assert_eq!(
pushes, 0,
"the success tail (record_push) must NOT run when the durable upload \
failed — the push was not durably accepted"
);
}

/// Repo creation must be throttled by the per-IP creation limiter BEFORE
/// signature verification — otherwise a DID farm (one throwaway did:key per
/// repo, each carrying a valid but machine-solved iCaptcha proof) walks past
Expand Down
18 changes: 16 additions & 2 deletions crates/gitlawb-node/src/git/repo_store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -602,11 +602,21 @@ impl RepoWriteGuard {
/// half-applied or otherwise inconsistent repo would propagate corruption to
/// Tigris (and to every node that later downloads it). The lock is always
/// released regardless, to avoid stale locks blocking future writes.
pub async fn release(mut self, success: bool) {
pub async fn release(mut self, success: bool) -> bool {
// Whether the durable copy is safe. Stays `true` when there is nothing to
// upload (no object store, or `success == false` where no upload is
// attempted) — those are not upload failures. Only an upload that was
// ATTEMPTED and then errored or timed out flips it `false`, which the
// caller surfaces as a FAILED push so the client re-pushes rather than
// trusting a commit that never reached durable storage. (P1 data-loss.)
let mut upload_ok = true;

// Upload to Tigris only on success. Bound the upload so a stalled PUT
// cannot pin the guard's advisory-lock connection indefinitely — on
// timeout we log and fall through to the unlock, returning the
// connection to the pool within the bound. (INV-22.)
// connection to the pool within the bound. (INV-22.) The lock is freed on
// EVERY arm below regardless of `upload_ok`; only the return value tells
// the caller whether the durable write landed.
if success {
if let Some(ref tigris) = self.object_store {
match tokio::time::timeout(
Expand All @@ -617,9 +627,11 @@ impl RepoWriteGuard {
{
Ok(Ok(())) => {}
Ok(Err(e)) => {
upload_ok = false;
warn!(repo = %self.repo_name, err = %e, "failed to upload repo to tigris after write");
}
Err(_) => {
upload_ok = false;
warn!(repo = %self.repo_name, timeout_secs = self.release_upload_timeout.as_secs(),
"tigris upload timed out after write — releasing the advisory lock without a completed upload");
}
Expand All @@ -640,6 +652,8 @@ impl RepoWriteGuard {
.execute(&mut *conn)
.await;
}

upload_ok
}
}

Expand Down