Remove the gutenberg domain from the dynamic blocks #12108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
force-pushed
the
remove/gutenberg-domain
branch
from
5fb60e7 to
3277d03
Compare
mcsf
approved these changes
Nov 20, 2018
daniloercoli
added a commit
that referenced
this pull request
Nov 20, 2018
…rnmobile/wire-on-replace-para-block * 'master' of https://github.com/WordPress/gutenberg: Remove "permalink settings" link from permalink panel. (#12121) preserve quote content (#12122) Replace gutenberg domain with default for Core blocks (#12108) Fix issue with disabled togglecontrol double border (#12091) Fix the TinyMCE init array (#10968)
Member
|
@youknowriad Why the explicit replacement instead of just omitting the text domain altogether? It's quite odd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10788
Removes the "gutenberg" domain from the block library translations as these files are consumed in Core.