Skip to content

Conversation

@ellatrix
Copy link
Member

@ellatrix ellatrix commented Nov 20, 2018

closes #10456

Description

Ensure content we can't handle is preserved in HTML block.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ellatrix ellatrix added this to the 4.5 milestone Nov 20, 2018
@ellatrix ellatrix requested a review from a team November 20, 2018 16:26
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does make sense for me to only convert if the quote block supports the content. (If it's only paragraphs inside the quote)

@youknowriad youknowriad merged commit c97cec8 into master Nov 20, 2018
@ellatrix ellatrix deleted the try/preserve-quote branch November 20, 2018 17:13
daniloercoli added a commit that referenced this pull request Nov 20, 2018
…rnmobile/wire-on-replace-para-block

* 'master' of https://github.com/WordPress/gutenberg:
  Remove "permalink settings" link from permalink panel. (#12121)
  preserve quote content (#12122)
  Replace gutenberg domain with default for Core blocks (#12108)
  Fix issue with disabled togglecontrol double border (#12091)
  Fix the TinyMCE init array (#10968)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Press This quoted content is partially lost when converting to blocks

3 participants