[RNMobile] Remove devOnly flag from Group block #20004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbinda
added
[Feature] Blocks
2 tasks
Contributor
|
@jbinda |
Contributor
Author
|
Sure, done. |
3 tasks
pinarol
requested review from
geriux
and removed request for
lukewalczak and
pinarol
3 tasks
geriux
approved these changes
Feb 5, 2020
Member
There was a problem hiding this comment.
This is working great on wordpress-mobile/WordPress-iOS#13367 👏
Amazing work! I did some inception tests nesting different blocks and groups within groups and it didn't break 😏🙌 (besides the other suggested test cases that all worked flawlessly too)
Tested only on iOS
Pending Android
Contributor
Author
|
@geriux Thanks for testing and feedback ! |
chipsnyder
approved these changes
Feb 5, 2020
Contributor
chipsnyder
left a comment
chipsnyder
left a comment
There was a problem hiding this comment.
Looks great on Android as well wordpress-mobile/WordPress-Android#11231 🚀
Contributor
Author
|
Once again thanks for testing, merged ! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Open Group Block for production by removing
devOnlyflag according to this ticketPlease also refer to:
Related gutenberg-mobile PR
How has this been tested?
WordPress iOS-> wordpress-mobile/WordPress-iOS#13367WordPress Android-> wordpress-mobile/WordPress-Android#11231Types of changes
New feature (Group block)
Checklist: