Feat: Open Group block for production #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbinda
added
[Type] Enhancement
6 tasks
Contributor
pinarol
requested review from
chipsnyder and
geriux
and removed request for
pinarol
Contributor
|
@chipsnyder @geriux After main APP PRs are created, could you please take one platform for yourself and test the Group block? I recommend using the peril links main app PR will give us and directly installing the apps in real device. Recommended test steps can be found here but no need to limit yourselves with those. Thanks! |
jbinda
force-pushed
the
callstack/open-group-block
branch
from
fb4a5c6 to
720e8f9
Compare
Contributor
|
Hey @chipsnyder 👋 I'll check it out on iOS 🍎 |
geriux
approved these changes
Feb 5, 2020
Contributor
There was a problem hiding this comment.
Approved the iOS side by WordPress/gutenberg#20004 (review)
chipsnyder
approved these changes
Feb 5, 2020
Contributor
chipsnyder
left a comment
chipsnyder
left a comment
There was a problem hiding this comment.
Approved on the Android side as well. Looks good 👍 WordPress/gutenberg#20004 (review)
This reverts commit 720e8f9.
Contributor
Author
|
merged ! 🎉 |
This was referenced Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1824
PR opens
Groupblock for production..Please also refer to:
Related gutenberg PR
Related gutenberg-mobile issue
WordPress iOS-> wordpress-mobile/WordPress-iOS#13367WordPress Android-> wordpress-mobile/WordPress-Android#11231PR submission checklist:
RELEASE-NOTES.txtif necessary.